Merge pull request #57 from Puckoland/agentAbstractClassImprovements

refactor: Move common attributes to Agent class

generals/agents/agent.py

@@ -6,11 +6,12 @@ class Agent:
     Base class for all agents.
     """
 
-    def __init__(self):
-        pass
+    def __init__(self, name, color):
+        self.name = name
+        self.color = color
 
     @abstractmethod
-    def play(self):
+    def play(self, observation):
         """
         This method should be implemented by the child class.
         It should receive an observation and return an action.

generals/agents/expander_agent.py

@@ -6,8 +6,7 @@
 
 class ExpanderAgent(Agent):
     def __init__(self, name="Expander", color=(0, 130, 255)):
-        self.name = name
-        self.color = color
+        super().__init__(name, color)
 
     def play(self, observation):
         """

generals/agents/random_agent.py

@@ -6,8 +6,7 @@ class RandomAgent(Agent):
     def __init__(
         self, name="Random", color=(255, 0, 0), split_prob=0.25, idle_prob=0.05
     ):
-        self.name = name
-        self.color = color
+        super().__init__(name, color)
 
         self.idle_probability = idle_prob
         self.split_probability = split_prob