Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: detect "vendor" folder for local builds #291

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

boojamya
Copy link
Contributor

When using the --local flag, this adds support for chains that choose to vendor all their Go dependancies.

Also updates docker.

@vimystic
Copy link
Contributor

Question: The vendor dir will be something one would locally use with their own dependancies?
i.e : there is no expectation of a vendor dir living in the repo, correct?

@boojamya
Copy link
Contributor Author

running go mod vendor will download and place all of the project dependancies in a "vendor" folder. Running go build -mod=vendor will tell go to build the project from the vendor folder instead of fetching all deps from the internet.

I think it is safe to assume that go projects should not have a vendor folder unless they are "vendoring" dependencies.

@vimystic vimystic self-requested a review October 11, 2024 15:30
@vimystic vimystic merged commit b675b55 into strangelove-ventures:main Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants