-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename and flesh out PR template #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! had a few comments but otherwise this seems good to go.
Signed-off-by: Sean Beckett <[email protected]>
Signed-off-by: Sean Beckett <[email protected]>
Signed-off-by: Sean Beckett <[email protected]>
Signed-off-by: Sean Beckett <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple more comments but nothing huge that should serve as a blocker. i'll approve this now so i'm not a blocker for getting it merged!
rename file to canonical GH pattern.
update file with checklist and sections to be filled out for PR submitters, including links to relevant does (some of which are still pending in other PRs)