Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename and flesh out PR template #18

Merged
merged 8 commits into from
May 28, 2024
Merged

Conversation

beckettsean
Copy link
Contributor

rename file to canonical GH pattern.

update file with checklist and sections to be filled out for PR submitters, including links to relevant does (some of which are still pending in other PRs)

@beckettsean beckettsean requested a review from jtieri May 15, 2024 16:16
@beckettsean beckettsean requested a review from a team as a code owner May 15, 2024 16:16
@beckettsean beckettsean changed the title rename and flesh out PR template chore: rename and flesh out PR template May 15, 2024
@beckettsean
Copy link
Contributor Author

Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! had a few comments but otherwise this seems good to go.

.github/PULL_REQUEST_TEMPLATE/pull_request_template.MD Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE/pull_request_template.MD Outdated Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE/pull_request_template.MD Outdated Show resolved Hide resolved
Copy link
Member

@jtieri jtieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple more comments but nothing huge that should serve as a blocker. i'll approve this now so i'm not a blocker for getting it merged!

@jtieri jtieri merged commit f9fc72b into main May 28, 2024
2 of 6 checks passed
@jtieri jtieri deleted the beckettsean-pr-template-1 branch May 28, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants