fix!: persist new vals to the base comet state #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reecepbcups
changed the title
Reecepbcups
changed the title
Reecepbcups
changed the title
* `UpdatedValidatorsCacheKey` * ABCI: `DeleteValidatorByPowerIndex` logic * validate ABCI events are not stuck * wait for blocks jail test * BeforeJailedValidatorsKey * lint + fix remove val test (check bonded) * lint * logs * touchups
Reecepbcups
changed the title
Reecepbcups
changed the title
Reecepbcups
changed the title
Reecepbcups
commented
Apr 15, 2024
Comment on lines
+124
to
+135
| // TODO: If this is used here, it persist ABCI Updates. When removes, it looks like the validator gets slashed every block in x/staking? (when we do the hack and force set jailed = false) | ||
| // if err := sk.DeleteLastValidatorPower(ctx, valAddr); err != nil { | ||
| // return err | ||
| // } | ||
|
|
||
| // !IMPORTANT HACK: Set validator from jailed to not jailed to see what happens | ||
| // Okay so this like kind of worked for a split second | ||
| // Issue: the validator keeps trying to be converted to a jailed validator every single block when x/staking is calling it | ||
| val.Jailed = false | ||
| if err := sk.SetValidator(ctx, val); err != nil { | ||
| return err | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Found by ethos in testing. Original #149
Despite PoA depending on x/staking for it's EndBlock actions, it was not persisting when changing Power amounts for new validators -> CometBFT consensus.
This PR has an issue where jailed validators attempt to jail per block. But it's large enough to merge to main
The "new" test are just copy paste from the previous monolithic test (TestPOA). Just added wait for blocks at the end of some to ensure ABCI val update events do not get stuck
Final