Recommended: Front end JavaScript changes

[justintadlock]

Is jQuery necessary?

In your memberlite.js and navigation.js files, which are loaded on the front end, you have just a few dozen lines of code. Both of these scripts rely on jQuery. Is it really necessary in this case? It looks like this can all be rewritten in vanilla JS and CSS with minimal effort. Then, there'd be no need to load an additional 95kb file just to run your little bit of JS. It could potentially shave off some loading time for some of your users. Definitely something to think about.

You're also erroneously setting jquery as a dependency for skip-link-focus-fix.js in functions.php on line 23 (it doesn't rely on it):

wp_enqueue_script('memberlite-skip-link-focus-fix', get_template_directory_uri() . '/js/skip-link-focus-fix.js', array( 'jquery' ), MEMBERLITE_VERSION, true);

For the admin and customizer JS, this is a non-issue since jQuery is definitely going to be loaded there anyway.

Combining files:

I'd also consider combining memberlite.js, navigations.js, and skip-link-focus-fix.js for the production release.

[ideadude]

I merged the 3 frontend JS into one file.

For now, we will still require jQuery here to save the time of refactoring, but updating status on this issue to work on that for a future release.

[kimcoleman]

PR here offers a jQuery free solution: https://github.com/strangerstudios/memberlite/pull/117/files

This needs testing but will address the issue.