Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No jQuery - Replace with native JavaScript #117

Closed
wants to merge 11 commits into from
Closed

No jQuery - Replace with native JavaScript #117

wants to merge 11 commits into from

Conversation

ipokkel
Copy link
Member

@ipokkel ipokkel commented Jul 17, 2019

– Replaced JQuery with vanilla JavaScript
– Improved smooth scroll
– Add CSS smooth scroll to CSS on condition that browser settings supports and if reduced motion isn’t true *(https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior#Accessibility_concerns)

  • Polyfills set to load conditionally for IE
  • Transapiled to ES5 for older browser compatibility
  • Convert Nodelists to Arrays for IE compatibility on array.foreach
  • html5shiv.js for IE HTML5 support, loads conditionally from CDN
  • respond.js for IE 8 media query support, loads conditionally from CDN

@kimcoleman
Copy link
Member

This would close issue #56

Copy link

@sc0ttkclark sc0ttkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial questions here

functions.php Outdated Show resolved Hide resolved
functions.php Outdated Show resolved Hide resolved
functions.php Outdated Show resolved Hide resolved
functions.php Outdated Show resolved Hide resolved
functions.php Outdated Show resolved Hide resolved
@sc0ttkclark sc0ttkclark self-assigned this Oct 27, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants