Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/add atts to pmpro levels block #2977

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Enhancement/add atts to pmpro levels block #2977

wants to merge 3 commits into from

Conversation

MaximilianoRicoTabo
Copy link
Contributor

@MaximilianoRicoTabo MaximilianoRicoTabo commented Apr 25, 2024 •
edited
Loading

All Submissions:

image image image image

Changes proposed in this Pull Request:

Resolves XXX.

How to test the changes in this Pull Request:

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@MaximilianoRicoTabo
Add atts support to pmpro levels shortcode
c2f3fa7 
 * Pass atta to load template function
 * Check atts during loop and skip those groups and levels not present if atts came
@MaximilianoRicoTabo
* Sanitize level page atts
170bf99
@MaximilianoRicoTabo
Add atts support to pmpro levels block
7c43958 
 * Add new levels and groups file that add a set of checkboxes based on existing Groups and levels
 * Pass these new attributes from block to render block page.
 * Call the render template function with the new attributes
@andrewlimaza andrewlimaza mentioned this pull request Apr 26, 2024
Closed
5 tasks
@andrewlimaza andrewlimaza marked this pull request as draft April 30, 2024 11:53
@dparker1005 dparker1005 added this to the Backlog milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewlimaza andrewlimaza Awaiting requested review from andrewlimaza

@dparker1005 dparker1005 Awaiting requested review from dparker1005

@kimcoleman kimcoleman Awaiting requested review from kimcoleman

Assignees
No one assigned
Labels
Impact: Low Status: Needs Thought Type: Enhancement
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@MaximilianoRicoTabo @dparker1005 @ideadude