Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Stripe cancelSubscriptionAtGateway for subs table #3178

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

dparker1005
Copy link
Member

All Submissions:

Changes proposed in this Pull Request:

Updated the cancelSubscriptionAtGateway() method of the Stripe Gateway clas to reference subscriptions instead of orders.

This PR also fixes an issue when PMPro tries to cancel a subscription in Stripe, but the subscription is already "scheduled for cancellation" in Stripe. In this case, $subscription->canceled_at would be set for the future and this method would bail early. This may happen in cases where a customer requests cancellation via the Stripe Customer Portal and Stripe tries to use their own CONPD behavior.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

Copy link
Member

@kimcoleman kimcoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested where we were seeing this error on our live site and it was successfully cancelled. Approved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants