Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Child pricing by amount Variable seat pricing cost #29

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

MaximilianoRicoTabo
Copy link
Contributor

  • Add new price setting option
  • Revamp JS file.
  • Add markup to support new options in edit-level file
  • Add new option to checkout page
image image image

All Submissions:

Changes proposed in this Pull Request:

Resolves #21

How to test the changes in this Pull Request:

  1. Checkout this branch
  2. Go to admin
  3. Play with the settings.
  4. Save a level with variable model pricing and an appropriate range
  5. Try checkout page with diffferent ranges

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

 * Add new price setting option
 * Revamp JS file.
 * Add markup to support new options in edit-level file
 * Add new option to checkout page
@andrewlimaza andrewlimaza marked this pull request as draft February 15, 2024 07:13
@andrewlimaza
Copy link

I've converted this PR to a draft as it may require more work to the UI/UX side of things but it is a good start.

@dparker1005
Copy link
Member

dparker1005 commented Feb 15, 2024

Before we merge this, we need to clarify between two similar, but distinct, pricing models.

If we take this example:
From 1-5: $100
From 6-10: $90

If a user purchases 8 seats, some sites may expect this to charge $720 ($90x8) and some sites may expect this to charge $770 ($100x5 + $90x3).

The distinction that needs to be made is whether "if you buy between x and y seats, each seat costs $z" or if "the first a seats cost $b, the next c seats cost $d, etc etc".

I think we eventually want both of these pricing models, and eventually we'll probably also want one where purchasing between a and b seats is a flat price of $c, purchasing between x and y seats is a flat price of $d, etc etc

@dparker1005
Copy link
Member

Stripe does this really well. See volume-based pricing vs graduated pricing in their docs here: https://docs.stripe.com/products-prices/pricing-models#tiered-pricing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Child pricing by amount Variable seat pricing cost
3 participants