Add formatted workout steps to Garmin activities #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PabiGamito
changed the title
PabiGamito
commented
Sep 28, 2024
| @@ -307,6 +312,88 @@ export class FitParser { | |||
| logger.info("FitParser.parse", logHelper.user(user), logHelper.fitFileActivity(fitFileActivity), `Data: ${logFields.join(", ")}`) | |||
| } | |||
|
|
|||
| private intensity_prefixes = { | |||
| "warmup": "🟢 Warmup: ", | |||
There was a problem hiding this comment.
I assume we probably want to do something with localization of the text here
PabiGamito
commented
Sep 28, 2024
| switch (step.target_type) { | ||
| case "speed": | ||
| if (step.target_value) { | ||
| line += ` @ ${this.formatSpeedAsPace(step.target_value)}` |
There was a problem hiding this comment.
This is specific to running. We probably want to format this for cycling activities in a way that makes sense for cycling workouts. Plus we should add support for power and heart rate target types as well.
PabiGamito
commented
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds formatted workout steps like the following:
This is something I currently do manually for all my workout activities and so it would love for this to be automated through Strautomator.