Port Modular Layouts to React #4764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BundleMonFiles updated (2)
Unchanged files (2)
Total files change +42.91KB +0.37% Final result: ✅ View report in BundleMon website ➡️ |
holiber
reviewed
Dec 7, 2023
holiber
reviewed
Dec 7, 2023
michelinewu
approved these changes
Dec 7, 2023
| <div className={styles.rows} ref={componentRef}> | ||
| <div | ||
| className={styles.cell} | ||
| style={{ height: `${100 - (resizes.bar1 + resizes.bar2!) * 100}%` }} |
There was a problem hiding this comment.
In what instances would resizes.bar2 be null?
There was a problem hiding this comment.
About half of the layouts only have one resizable bar so it has to be an optional/nullable parameter, but we know which layouts in which 2 resize bars exist so we are able to safely assert them
holiber
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.