revert spotbugs problem change

streamnative · Jul 12, 2023 · 11f3393 · 11f3393
1 parent 234ce4d
commit 11f3393
Showing 1 changed file with 5 additions and 12 deletions.
diff --git a/...reamnative/pulsar/handlers/kop/storage/PulsarTopicProducerStateManagerSnapshotBuffer.java b/...reamnative/pulsar/handlers/kop/storage/PulsarTopicProducerStateManagerSnapshotBuffer.java
@@ -83,18 +83,11 @@ private synchronized void discardReader(Reader<ByteBuffer> oldReader) {
         if (reader == null) {
             return;
         }
-        if (reader.isDone() && !reader.isCompletedExceptionally()) {
-            Reader<ByteBuffer> newReader = null;
-            try {
-                newReader = reader.get(0, TimeUnit.MILLISECONDS);
-                if (newReader == oldReader) {
-                    log.info("discard broken reader for {}", topic);
-                    reader = null;
-                }
-            } catch (Exception exception) {
-                log.warn("Failed to get reader handle for topic {}, discard the reader.", topic, exception);
-                reader = null;
-            }
+        if (reader.isCompletedExceptionally() || (reader.isDone()
+                && !reader.isCompletedExceptionally()
+                && reader.getNow(null) == oldReader)) {
+            log.info("discard broken reader for {}", topic);
+            reader = null;
         }
     }