This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[tests] Prevent test timeouts due to pulsar client hanging while shutdown #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eolivelli
requested review from
BewareMyPower and
Demogorgon314
as code owners
|
With this patch my CI is far more stable I suggest to merge in to KOP |
BewareMyPower
approved these changes
Feb 22, 2023
eolivelli
added a commit
to eolivelli/kop
that referenced
this pull request
Feb 28, 2023
…down (streamnative#1731) ### Motivation Sometimes tests hang during teardown because the shutdown procedure of the broker is blocked in waiting for our PulsarClients to close. ### Modifications Wait for some time. I have filed this issue upstream in Pulsar in order to have a better management of this problem apache/pulsar#19579
BewareMyPower
added
release/2.11
cherry-picked/branch-2.11
and removed
cherry-picked/branch-2.11
labels
BewareMyPower
pushed a commit
that referenced
this pull request
Jul 17, 2023
…down (#1731) ### Motivation Sometimes tests hang during teardown because the shutdown procedure of the broker is blocked in waiting for our PulsarClients to close. ### Modifications Wait for some time. I have filed this issue upstream in Pulsar in order to have a better management of this problem apache/pulsar#19579 (cherry picked from commit 37b1abe)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes tests hang during teardown because the shutdown procedure of the broker is blocked in waiting for our PulsarClients to close.
Modifications
Wait for some time.
I have filed this issue upstream in Pulsar in order to have a better management of this problem
apache/pulsar#19579
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)