This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[transaction] Recover from temporary errors on PulsarTopicProducerStateManagerSnapshotBuffer #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hotBuffer.java (cherry picked from commit 3a61fdb)
…d failred Readers (cherry picked from commit 3333cef)
Codecov Report
@@ Coverage Diff @@
## master #1946 +/- ##
============================================
- Coverage 17.83% 17.69% -0.14%
Complexity 752 752
============================================
Files 195 195
Lines 14081 14193 +112
Branches 1311 1327 +16
============================================
+ Hits 2511 2512 +1
- Misses 11388 11499 +111
Partials 182 182
|
|
spotbugs-check problem spotbugs/spotbugs#1001 |
(cherry picked from commit 8f65791)
| .topic(topic) | ||
| .startMessageId(MessageId.earliest) | ||
| .readCompacted(true) | ||
| .createAsync(); | ||
| reader = newReader; | ||
|
|
||
| newReader.whenComplete((r, error) -> { |
There was a problem hiding this comment.
Can we add a unit test for this case?
There was a problem hiding this comment.
Sorry for not getting back to you sooner. I found this change may cause NPE problems, I add NPE checks and unit tests, maybe we don't need to merge this PR immediately.
gaoran10
changed the title
gaoran10
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 3a61fdb)
Motivation
Recover from temporary errors on PulsarTopicProducerStateManagerSnapshotBuffer.
Modifications
Discard invalid readers and producers for producer state manager snapshot topics.
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)