Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

[transaction] Use a dedicated timeout for writing transaction marker #1968

Conversation

gaoran10
Copy link
Contributor

(cherry picked from commit e1e4562)

Modifications

Use a dedicated timeout for writing transaction marker

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

…geAbortedTxnIntervalSeconds by default

(cherry picked from commit e1e4562)
@gaoran10 gaoran10 self-assigned this Jul 20, 2023
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jul 20, 2023
@gaoran10 gaoran10 added release/2.11 release/2.10.4 release/3.0 and removed no-need-doc This pr does not need any document labels Jul 20, 2023
@github-actions
Copy link

@gaoran10:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

1 similar comment
@github-actions
Copy link

@gaoran10:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jul 20, 2023
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #1968 (64f2c2d) into master (1dda879) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1968      +/-   ##
============================================
+ Coverage     17.72%   17.74%   +0.02%     
- Complexity      751      752       +1     
============================================
  Files           195      195              
  Lines         14155    14154       -1     
  Branches       1322     1322              
============================================
+ Hits           2509     2512       +3     
+ Misses        11463    11460       -3     
+ Partials        183      182       -1     
Impacted Files Coverage Δ
...ative/pulsar/handlers/kop/KafkaRequestHandler.java 1.06% <ø> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

* Writing the TXMARKERS require recovery of the
* transactions on the PartitionLog at it may take much time.
*/
private static final int WRITE_TXN_MARKERS_TIMEOUT = 120000;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to use this dedicated timeout?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only because we had problems during failure injection tests and we had to troubleshot.
it is a left over

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll close this PR first.

@gaoran10 gaoran10 changed the title Use a dedicated timeout for writing transaction marker [transaction] Use a dedicated timeout for writing transaction marker Jul 24, 2023
* Writing the TXMARKERS require recovery of the
* transactions on the PartitionLog at it may take much time.
*/
private static final int WRITE_TXN_MARKERS_TIMEOUT = 120000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was only because we had problems during failure injection tests and we had to troubleshot.
it is a left over

@gaoran10
Copy link
Contributor Author

gaoran10 commented Jul 26, 2023

Close this PR first, refer to #1968 (comment)

@gaoran10 gaoran10 closed this Jul 26, 2023
@gaoran10 gaoran10 deleted the use_a_dedicated_timeout_for_writing_txn_marker branch July 26, 2023 05:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
doc-info-missing This pr needs to mark a document option in description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants