[transaction] Use a dedicated timeout for writing transaction marker #1968
Conversation
…geAbortedTxnIntervalSeconds by default (cherry picked from commit e1e4562)
gaoran10
added
release/2.11
release/2.10.4
release/3.0
and removed
no-need-doc
|
@gaoran10:Thanks for your contribution. For this PR, do we need to update docs? |
1 similar comment
|
@gaoran10:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
Codecov Report
@@ Coverage Diff @@
## master #1968 +/- ##
============================================
+ Coverage 17.72% 17.74% +0.02%
- Complexity 751 752 +1
============================================
Files 195 195
Lines 14155 14154 -1
Branches 1322 1322
============================================
+ Hits 2509 2512 +3
+ Misses 11463 11460 -3
+ Partials 183 182 -1
|
| * Writing the TXMARKERS require recovery of the | ||
| * transactions on the PartitionLog at it may take much time. | ||
| */ | ||
| private static final int WRITE_TXN_MARKERS_TIMEOUT = 120000; |
There was a problem hiding this comment.
Why do we need to use this dedicated timeout?
There was a problem hiding this comment.
This was only because we had problems during failure injection tests and we had to troubleshot.
it is a left over
There was a problem hiding this comment.
Thanks, I'll close this PR first.
gaoran10
changed the title
| * Writing the TXMARKERS require recovery of the | ||
| * transactions on the PartitionLog at it may take much time. | ||
| */ | ||
| private static final int WRITE_TXN_MARKERS_TIMEOUT = 120000; |
There was a problem hiding this comment.
This was only because we had problems during failure injection tests and we had to troubleshot.
it is a left over
|
Close this PR first, refer to #1968 (comment) |
(cherry picked from commit e1e4562)
Modifications
Use a dedicated timeout for writing transaction marker
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)