This repository has been archived by the owner on Jan 24, 2024. It is now read-only.
[fix] Memory leak of the map in ThreadLocalAccessor #2006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: streamnative#1956 ### Modifications Update stats on the netty threads to fix the stats memory leak issue. The root cause is we can only use `DataSketchesOpStatsLogger` in the netty thread. When used in other threads, it will cause memory leak, since the `FastThreadLocal` can't remove the map if the thread is not netty thread.
Demogorgon314
approved these changes
Sep 20, 2023
Codecov Report
@@ Coverage Diff @@
## master #2006 +/- ##
============================================
- Coverage 17.06% 16.98% -0.09%
+ Complexity 731 730 -1
============================================
Files 191 191
Lines 14277 14307 +30
Branches 1340 1339 -1
============================================
- Hits 2437 2430 -7
- Misses 11663 11701 +38
+ Partials 177 176 -1
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1956
Modifications
Update stats on the netty threads to fix the stats memory leak issue.
The root cause is we can only use
DataSketchesOpStatsLoggerin the netty thread. When used in other threads, it will cause memory leak, since theFastThreadLocalcan't remove the map if the thread is not netty thread.Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)