Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump jsdom from 22.1.0 to 23.0.0 in /export-server #11

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 27, 2023

Bumps jsdom from 22.1.0 to 23.0.0.

Release notes

Sourced from jsdom's releases.

Version 23.0.0

  • Node.js v18 is now the minimum supported version.
  • Updated various dependencies, including whatwg-url which integrates various additions to the URL and URLSearchParams objects.
Changelog

Sourced from jsdom's changelog.

23.0.0

  • Node.js v18 is now the minimum supported version.
  • Updated various dependencies, including whatwg-url which integrates various additions to the URL and URLSearchParams objects.
Commits
  • b968889 23.0.0
  • 59ebd7e Use modern pathToFileURL in tests
  • 1ee4d61 Update dependencies and dev dependencies
  • 6626781 Remove the domexception package dependency
  • 6d9ff2c Remove abab dependency
  • 7027a3d Move from yarn to npm
  • 9b354af Raise minimum Node.js version to v18
  • 032df9c Reflect the move from master to main
  • a39e0ec Disable another newly-flaky XHR test
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 27, 2023
@dependabot dependabot bot requested a review from striezel November 27, 2023 14:46
Copy link
Owner

@striezel striezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also results in a Node.js version bump without actually getting any significant new features or bug fixes from the dependency update, so I'm not sure wheter this is a good idea at the moment.

@striezel striezel self-requested a review November 28, 2023 23:22
Copy link
Owner

@striezel striezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the end of life for Node.js 16 has been moved from April 2024 to September 2023: https://nodejs.org/en/blog/announcements/nodejs16-eol/ So both Node.js 16 and 17 have reached their end of life and the requirement to have at least Node.js 18 would be no serious restriction anymore.

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/export-server/jsdom-23.0.0 branch from 50f4a75 to 7274b59 Compare November 29, 2023 22:37
Bumps [jsdom](https://github.com/jsdom/jsdom) from 22.1.0 to 23.0.0.
- [Release notes](https://github.com/jsdom/jsdom/releases)
- [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md)
- [Commits](jsdom/jsdom@22.1.0...23.0.0)

---
updated-dependencies:
- dependency-name: jsdom
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/export-server/jsdom-23.0.0 branch from 7274b59 to dabf00c Compare November 30, 2023 00:37
Copy link
Contributor Author

dependabot bot commented on behalf of github Nov 30, 2023

Superseded by #12.

@dependabot dependabot bot closed this Nov 30, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/export-server/jsdom-23.0.0 branch November 30, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant