Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Java 11 to 17 #26

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Upgrade Java 11 to 17 #26

merged 1 commit into from
Aug 22, 2024

Conversation

JiriOndrusek
Copy link
Contributor

fixes #25

@scholzj scholzj requested a review from see-quick May 16, 2024 08:06
@scholzj
Copy link
Member

scholzj commented May 16, 2024

Out of curiosity, what is the use case for running the test container on FIPS? Also as a sidenote, Java 17 might not be enough for that - it requires use of some specific parameters when creating the PKCS12 stores etc.

@scholzj
Copy link
Member

scholzj commented May 16, 2024

@see-quick What is the impact if this uses Java 17 on the things such as Bridge based on Java 11? I assume no impact as long as it is only the container image using Java 17 and not the test container code itself?

@JiriOndrusek
Copy link
Contributor Author

I was trying to make a camel-quarkus test for kafka run on FIPS. My work canbe seen here: apache/camel-quarkus#6091
I was able to customize the image by installing java 17 during runtime. I was able to run the tests on the FIPs system (when using j17). Of course I had to create a PKCS12 stores correctly.

@JiriOndrusek
Copy link
Contributor Author

@scholzj I'm no expert on kafka. I just noticed that according to the blog post (from the summary), kafka requires J17 to run on fIPs. I tried to achieve this and from my perspective it works as expected. Therefore I proposed this PR with the fix.

@scholzj
Copy link
Member

scholzj commented May 16, 2024

@scholzj I'm no expert on kafka. I just noticed that according to the blog post (from the summary), kafka requires J17 to run on fIPs. I tried to achieve this and from my perspective it works as expected. Therefore I proposed this PR with the fix.

It is more about the OpenJDK 17 having many improvements in FIPS support rather than Kafka itself. But yes, the OpenJDK17 is important for this.

@scholzj
Copy link
Member

scholzj commented May 16, 2024

@JiriOndrusek Can you please fix the DCO signoff? The instructions should be under the Details link next to the DCO status in the PR status section.

Signed-off-by: JiriOndrusek <[email protected]>
@see-quick
Copy link
Member

I assume no impact as long as it is only the container image using Java 17 and not the test container code itself?

That's my guess also...as we know Java 17 is backward-compatible with Java 11 so code should run on Java 17 runtime without any problem.

@scholzj scholzj modified the milestones: 0.107.0, 0.108.0 Aug 22, 2024
@scholzj
Copy link
Member

scholzj commented Aug 22, 2024

Thanks for the PR. Sorry, it looks like it got forgotten for a long time :-(.

@scholzj scholzj merged commit e1fad4c into strimzi:main Aug 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade java 11 to 17 for the FIPs support.
4 participants