Add reporting chart beta component #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/types.ts
Outdated
| @@ -17,3 +17,7 @@ export type FinancingProductType = { | |||
| }; | |||
|
|
|||
| export type FinancingPromotionLayoutType = 'full' | 'banner'; | |||
|
|
|||
| export type IntervalType = 'day' | 'week' | 'month' | 'quarter' | 'year'; | |||
There was a problem hiding this comment.
We don't have to define these here - these can be imported from the connect-js repo
jorgea-stripe
approved these changes
Sep 19, 2024
neerajsamtani-stripe
force-pushed
the
neerajsamtani-add-reporting-chart-component
branch
from
ab21bc0
to
74ffb45
Compare
michaelphines-stripe
approved these changes
Oct 4, 2024
neerajsamtani-stripe
force-pushed
the
neerajsamtani-add-reporting-chart-component
branch
from
23da087
to
7a34a9c
Compare
michaelphines-stripe
deleted the
neerajsamtani-add-reporting-chart-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds ReportingChart to package