Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
pspieker-stripe committed Jun 21, 2024
1 parent 7e8daec commit 08e2921
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions pkg/smokescreen/smokescreen.go
Original file line number Diff line number Diff line change
Expand Up @@ -941,9 +941,12 @@ func checkACLsForRequest(config *Config, req *http.Request, destination hostport

if err != nil {
config.Log.WithFields(logrus.Fields{
"error": err,
"role": role,
}).Warn("Unable to parse X-Upstream-Https-Proxy header.")
"error": err,
"role": role,
"upstream_proxy_name": req.Header.Get("X-Upstream-Https-Proxy"),
"destination_host": destination.Host,
"kind": "parse_failure",
}).Error("Unable to parse X-Upstream-Https-Proxy header.")

config.MetricsClient.Incr("acl.upstream_proxy_error", 1)
return decision
Expand Down

0 comments on commit 08e2921

Please sign in to comment.