Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure proxy passed in X-Upstream-Https-Proxy is parsable #224

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

gauthamw-stripe
Copy link
Collaborator

Description

Ensure that the https proxy passed in X-Upstream-Https-Proxy can be parsed before proceeding.

Testing Details

curl --proxy-header "X-Upstream-Https-Proxy: google.com:443" --proxytunnel -x localhost:4750 https://example3.com

Logs:

{"destination_host":"example3.com","error":"proxy header contains invalid URL. The correct format is https://[username:password@]my.proxy.srv:12345","kind":"parse_failure","level":"error","msg":"Unable to parse X-Upstream-Https-Proxy header.","role":"","time":"2024-09-05T01:57:45+05:30","upstream_proxy_name":"google.com:443"}

@coveralls
Copy link

coveralls commented Sep 4, 2024

Pull Request Test Coverage Report for Build 10709127600

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 62.494%

Totals Coverage Status
Change from base Build 9899373120: 0.6%
Covered Lines: 1318
Relevant Lines: 2109

💛 - Coveralls

Copy link
Collaborator

@jjiang-stripe jjiang-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks for fixing the tests too!

@gauthamw-stripe gauthamw-stripe merged commit 149b19d into master Sep 4, 2024
5 checks passed
@gauthamw-stripe gauthamw-stripe deleted the gauthamw/https-proxy branch September 4, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants