Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Add Sail colors to ui core module and StripeTheme #7796

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

carlosmuvi-stripe
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe commented Jan 19, 2024

Summary

  • Introduces SailColors on the ui-core module, so that base components used across SDKs can make use of them
  • Provides SailColors via StripeTheme together with the existing theme values.

Also showcases its usage on the PhoneInput component:

image

Motivation

📔  Add Sail colors to ui core module and StripeTheme
🌐  BANKCON-8927

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@carlosmuvi-stripe carlosmuvi-stripe added the work-cli Added to pull requests created with #work-cli for usage tracking. label Jan 19, 2024
@carlosmuvi-stripe carlosmuvi-stripe self-assigned this Jan 19, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this file impact PaymentSheet. Can you undo them or find a way to have both old and new?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! this is just a showcase : ) I'll revert the actual usage

@carlosmuvi-stripe carlosmuvi-stripe changed the title Add Sail colors to ui core module and StripeTheme [POC] Add Sail colors to ui core module and StripeTheme Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-cli Added to pull requests created with #work-cli for usage tracking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants