Networking Sign Up Pane (Native): Add back auto-focus

[carlosmuvi-stripe]

Summary

• Replaces activity resizing by insets (keyboard now smoothly animates)
• On signup pane, keeps bottom panel behind keyboard
• Focuses on email when empty
• Focuses on phone when email prefilled, but no phone prefilled
• Does not focus when both fields prefill.

no_prefill.mp4

email_prefill.mp4

both_filled.mp4

Motivation

📔  Networking Sign Up Pane (Native): Add back auto-focus
🌐  BANKCON-10945

On networking sign up pane:

1. if user has no email, we will auto-focus the keyboard on email and the "Not Now" button will be behind the keyboard (user can still easily dismiss keyboard or press the "X" button)
2. if user has no phone (but prefill email), we will auto-focus the keyboard on phone (other details apply as above ^)
3. if we prefill both, we don't auto-focus

PR's that removed it:

1. email: FC Networking: disabled autofocus on email field on SignUp pane. stripe-ios#2526
2. phone: FC Networking: disabled focusing phone field IF the email has been prefilled stripe-ios#2528

Testing

• Added tests
• Modified tests
• Manually verified

Screenshots

Before	After
before screenshot	after screenshot

Changelog

[github-actions]

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │ -1 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   7.3 MiB │   7.3 MiB │  0 B │  18.4 MiB │  18.4 MiB │  0 B 
    asset │   1.5 MiB │   1.5 MiB │  0 B │   1.5 MiB │   1.5 MiB │  0 B 
    other │    87 KiB │    87 KiB │ +8 B │ 161.5 KiB │ 161.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.2 MiB │  12.2 MiB │ +7 B │  25.8 MiB │  25.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21689 │ 21689 │ 0 (+1 -1) 
   types │  6869 │  6869 │ 0 (+0 -0) 
 classes │  5634 │  5634 │ 0 (+0 -0) 
 methods │ 31451 │ 31451 │ 0 (+0 -0) 
  fields │ 18315 │ 18315 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0

APK

   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 29.1 KiB │ +7 B │   64 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    271 B │ +1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
    2 MiB │ -1 B │  4.3 MiB │  0 B │ ∆ classes.dex                             
  1.2 KiB │ +1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
 25.9 KiB │ -1 B │ 63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
  2.1 MiB │ +7 B │  4.4 MiB │  0 B │ (total)

DEX

STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   21689 │ 21689 │ 0 (+1 -1) 
  
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:eccad00,r8-mode:full,version:8.3.37}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:0f80f6e,r8-mode:full,version:8.3.37}

[carlosmuvi-stripe]

hoisted imePadding a bit up so that users can customize it, and adds it for the Elements bottom sheet to keep current behavior.

[tillh-stripe]

Looks good!

[tillh-stripe]

Nit: I don’t think we need these comments, as the code already explains it :)

[tillh-stripe]

Nit: We don’t seem to use ifFalse. Should we rename this to fun Modifier.ifTrue(condition, action)?

[tillh-stripe]

Nit: Should we rename this to keepFooterAboveKeyboard or something more concrete than applyImePadding?

[tillh-stripe]

Same here.