Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Mockito from NetworkingLinkSignupViewModelTest #9071

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Aug 14, 2024

Summary

This pull request removes Mockito from NetworkingLinkSignupViewModelTest. It’s an example of how we should go about improving our unit tests going forward.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Aug 14, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   1.9 MiB │   1.9 MiB │  0 B │     4 MiB │     4 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.8 KiB │   6.8 KiB │  0 B │   6.5 KiB │   6.5 KiB │  0 B 
    other │  85.5 KiB │  85.5 KiB │ -3 B │ 158.7 KiB │ 158.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.5 MiB │   9.5 MiB │ -3 B │  21.4 MiB │  21.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20227 │ 20227 │ 0 (+0 -0) 
   types │  6086 │  6086 │ 0 (+0 -0) 
 classes │  4894 │  4894 │ 0 (+0 -0) 
 methods │ 29483 │ 29483 │ 0 (+0 -0) 
  fields │ 17371 │ 17371 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3608 │ 3608 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 25.1 KiB │ -4 B │  62.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
    270 B │ -2 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 28.3 KiB │ +2 B │  62.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │ +1 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 54.9 KiB │ -3 B │ 126.4 KiB │  0 B │ (total)

@tillh-stripe tillh-stripe force-pushed the tillh/remove-mockito-from-networking-signup-tests branch from dbeafaa to 1d37d22 Compare August 14, 2024 22:50
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test helper, since GetOrFetchSync can not be a functional interface.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test helper, since SaveAccountToLink can not be a functional interface (it has an email and an sms method).

@tillh-stripe tillh-stripe force-pushed the tillh/remove-mockito-from-networking-signup-tests branch from 1d37d22 to d1a4f6c Compare September 5, 2024 20:58
@tillh-stripe tillh-stripe force-pushed the tillh/remove-mockito-from-networking-signup-tests branch from d1a4f6c to bbd56c3 Compare September 5, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant