Use the generic title "Front of identity document" instead of "Front of identity card" #9188
+9
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #8511
This change is similar to:
Summary
Motivation
Because currently the title is always "Front of identity card" regardless of what is configured in
options.document.allowed_types
, users upload their "Identity card" (German: "Personalausweis") instead of the "Driver's license" (German: Führerschein"). So the more generic term "Identity document" should be used. This approach was also changed recently in stripe-ios here.The optimal solution would be that the title corresponds exactly with
options.document.allowed_types
. This is how the web version already does it.Example:
options.document.allowed_types
["driving_license"]
<string name="stripe_front_of_dl">Front of driver\'s license</string>
["id_card"]
<string name="stripe_front_of_id">Front of identity card</string>
["passport"]
<string name="stripe_passport">Passport</string>
["driving_license", "id_card", "passport"]
<string name="stripe_front_of_id_document">Front of identity document</string>
I've seen that with this commit in the PR
these new translations were added:
but they are not used in the code yet.
Testing
Screenshots
Changelog