Update PaymentSheet bottom paddings & error padding

[samer-stripe]

Summary

Update PaymentSheet bottom paddings & error padding

Motivation

Design decided to put the error message above the bottom content padding but with some extra padding between it and the rest of the card content. Also more accurately updated the PaymentSheet padding so that horizontal and vertical mode are matched.

Mock

Testing

• Added tests
• Modified tests
• Manually verified

[samer-stripe]

We weren't passing the modifier for the VerticalModeFormUI as well. Looks like because the form applies its own padding. Should we move the default modifier that applies 8.dp as bottom padding into the individual screens?

[amk-stripe]

I don't think the individual screens should be responsible for their own padding. In this case, we would need to add 8.dp to all the screens individually? So it just makes more sense to apply that padding globally.

Rather than doing this, I think we should remove the padding from the forms, if we need to

[github-actions]

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   1.9 MiB │   1.9 MiB │  0 B │     4 MiB │     4 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.8 KiB │   6.8 KiB │  0 B │   6.6 KiB │   6.6 KiB │  0 B 
    other │  85.5 KiB │  85.5 KiB │ -1 B │ 158.7 KiB │ 158.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.5 MiB │   9.5 MiB │ -1 B │  21.4 MiB │  21.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20269 │ 20269 │ 0 (+0 -0) 
   types │  6106 │  6106 │ 0 (+0 -0) 
 classes │  4913 │  4913 │ 0 (+0 -0) 
 methods │ 29561 │ 29561 │ 0 (+0 -0) 
  fields │ 17371 │ 17371 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3608 │ 3608 │  0

APK

   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 25.1 KiB │ -2 B │ 62.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
    272 B │ +1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 25.4 KiB │ -1 B │ 62.6 KiB │  0 B │ (total)

[amk-stripe]

I don't think the individual screens should be responsible for their own padding. In this case, we would need to add 8.dp to all the screens individually? So it just makes more sense to apply that padding globally.

Rather than doing this, I think we should remove the padding from the forms, if we need to

[amk-stripe]

if these have the same value, do we need to set this per-screen at all? Or can we just use 20.dp as bottom content padding in PaymentSheetScreen?

[samer-stripe]

Dropping this for now. Will be re-visited during embedded.