Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ElementsContext to Instant Debits flows #9251

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tillh-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Sep 12, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   3.9 MiB │   3.9 MiB │ +2.1 KiB │   8.6 MiB │   8.6 MiB │ +2.2 KiB 
     arsc │   2.3 MiB │   2.3 MiB │      0 B │   2.3 MiB │   2.3 MiB │      0 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │  25.6 KiB │  25.6 KiB │      0 B 
      res │ 932.5 KiB │ 932.5 KiB │      0 B │   1.5 MiB │   1.5 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │   2.9 MiB │   2.9 MiB │     +1 B │   2.9 MiB │   2.9 MiB │     +1 B 
    other │ 195.8 KiB │ 195.8 KiB │     -4 B │ 430.3 KiB │ 430.3 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.8 MiB │  12.8 MiB │ +2.1 KiB │  21.7 MiB │  21.7 MiB │ +2.2 KiB 

 DEX     │ old   │ new   │ diff           
─────────┼───────┼───────┼────────────────
   files │     1 │     1 │  0             
 strings │ 42596 │ 42602 │ +6 (+13 -7)    
   types │ 14110 │ 14112 │ +2 (+7 -5)     
 classes │ 11752 │ 11753 │ +1 (+3 -2)     
 methods │ 60308 │ 60317 │ +9 (+122 -113) 
  fields │ 39989 │ 39997 │ +8 (+197 -189) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6245 │ 6245 │  0
APK
     compressed      │     uncompressed     │                                           
──────────┬──────────┼───────────┬──────────┤                                           
 size     │ diff     │ size      │ diff     │ path                                      
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  3.9 MiB │ +2.1 KiB │   8.6 MiB │ +2.2 KiB │ ∆ classes.dex                             
 53.3 KiB │    -10 B │ 118.1 KiB │      0 B │ ∆ META-INF/CERT.SF                        
  7.8 KiB │     +4 B │   7.7 KiB │     +4 B │ ∆ assets/dexopt/baseline.prof             
    984 B │     -3 B │     852 B │     -3 B │ ∆ assets/dexopt/baseline.profm            
   50 KiB │     +3 B │ 118.1 KiB │      0 B │ ∆ META-INF/MANIFEST.MF                    
  1.2 KiB │     +2 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
    272 B │     +1 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
    4 MiB │ +2.1 KiB │   8.8 MiB │ +2.2 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   42596 │ 42602 │ +6 (+13 -7) 
  
  + , elementsContext=
  + ElementsContext(id=
  + LLLLLLLLLLLLL
  + LO6/T;
  + Lx5/E;
  + Lz3/v;
  + VLZLZZLZLLZL
  + [Lx5/b;
  + [Lx5/k;
  + [Lx5/o;
  + [Lx5/q;
  + financial_incentive
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:0bc3bb6,r8-mode:full,version:8.5.35}
  
  - LQ6/g;
  - LY6/e;
  - VLZLZZLZLLZ
  - [Lx5/h;
  - [Lx5/l;
  - [Lx5/p;
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:1600039,r8-mode:full,version:8.5.35}
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   14110 │ 14112 │ +2 (+7 -5) 
  
  + LO6/T;
  + Lx5/E;
  + Lz3/v;
  + [Lx5/b;
  + [Lx5/k;
  + [Lx5/o;
  + [Lx5/q;
  
  - LQ6/g;
  - LY6/e;
  - [Lx5/h;
  - [Lx5/l;
  - [Lx5/p;
  

METHODS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   60308 │ 60317 │ +9 (+122 -113) 
  
  + B5.d <init>(d, T, X)
  + B5.g <init>(a, a, a, a, a, a, a, a, int)
  + E5.d <init>(e, t, f, String)
  + E5.e <init>(e, String, t, f, m, a, int)
  + G5.c <init>(e, t, f, String, int)
  + H7.J <init>(d, int)
  + H7.J a(a, b)
  + H7.J b(String, String, c, String, String, Integer, String)
  + H7.J c(String, String, c, String, String)
  + H7.J d(String, String, String, d)
  + H7.J e(String, String, String, d)
  + H7.J f()
  + L7.x <init>(e, l, e, l, T, f, l, T, T, s)
  + O6.T <init>(l, X, f, s)
  + O6.T <init>(e, l, e, e, X, s)
  + O6.T <init>(e, h, h, X, h, h)
  + O6.T <init>(a, a, a, a, a, a, a, int)
  + O6.T get() → Object
  + Q6.a <init>(String, b)
  + Q6.e <init>(Object, int)
  + Q6.e a(Object)
  + Q6.f <init>(i, int)
  + Q6.f b() → c
  + Q6.f equals(Object) → boolean
  + Q6.f hashCode() → int
  + R7.d d(String, String, String, String, Locale, Long, String, Map, String, P, l, d) → Object
  + T6.a <init>(String, String, d, String, String, String, Integer, String)
  + T6.b <init>(String, String, d, String, String, String)
  + T6.c <init>(String, String, String, d, boolean)
  + T6.d <init>(String, String, String, d, boolean)
  + U6.d <init>(String, String, String, b)
  + U6.j <init>(p, l, d)
  + W6.k <clinit>()
  + W6.k <init>(c)
  + W6.k d(a, Object, l, c) → Object
  + W6.l <init>()
  + W6.l <init>(a, int)
  + W6.l get() → Object
  + Y6.b <init>(Z2, a, int)
  + Y6.c <init>(Z2, a, a, a, a, a, a, a, a, a, e)
  + Y6.c <init>(a, a, a, a, a, a, a, a, a, a, a)
  + Y6.d <clinit>()
  + b6.b <init>(a, b)
  + b6.m <init>(a, L2, b)
  + com.stripe.android.financialconnections.FinancialConnectionsSheetActivity h() → E
  + i6.i <init>(K, boolean, a, boolean, boolean, l, boolean, FinancialConnectionsSessionManifest_Pane, i, boolean, b)
  + j6.p <init>(a, a, J, b, Locale, d, b, o0)
  + n3.e B(e, t, f, String, v, int)
  + n3.e h(V, e, f, v, int)
  + n3.e l(w1, e, f, v, int)
  + n3.e m(e, String, t, f, m, a, v, int)
  + n3.e q(k, e, f, b, m, v, int)
  + q5.E0 <init>(Application, C, l, p, d, S, m, i, a, L, S0, a, u, f)
  + x5.A <init>(E, d)
  + x5.B <init>(E, d)
  + x5.C <init>(E, r, d)
  + x5.C J(Object, Object) → Object
  + x5.C e(d, Object) → d
  + x5.C i(Object) → Object
  + x5.D <init>(int, Object, Object)
  + x5.D L(Object) → Object
  + x5.E <clinit>()
  + x5.E <init>(String, k0, D, i, i, d, a, l, v, i, S, r)
  + x5.E f(Object) → c
  + x5.E h(E, r, Uri)
  + x5.E i(E, r, h, boolean, int)
  + x5.b <clinit>()
  + x5.b <init>(String, Long, String, String)
  + x5.b describeContents() → int
  + x5.b equals(Object) → boolean
  + x5.b hashCode() → int
  + x5.b toString() → String
  + x5.b writeToParcel(Parcel, int)
  + x5.c <init>(FinancialConnectionsSheetActivity, int)
  + x5.c a(Object)
  + x5.d <init>(FinancialConnectionsSheetActivity, d)
  + x5.e <init>(Y, FinancialConnectionsSheetActivity, p, d)
  + x5.e J(Object, Object) → Object
  + x5.e e(d, Object) → d
  + x5.e i(Object) → Object
  + x5.f <init>(int, Object, Class, String, String, int, int)
  + x5.f n() → Object
  + x5.g <init>(FinancialConnectionsSheetActivity, int)
  + x5.g J(Object, Object) → Object
  + x5.h n() → Object
  + x5.j <init>(U0, f3)
  + x5.k <clinit>()
  + x5.k <init>(Throwable)
  + x5.k describeContents() → int
  + x5.k equals(Object) → boolean
  + x5.k hashCode() → int
  + x5.k toString() → String
  + x5.k writeToParcel(Parcel, int)
  + x5.n <init>(U0)
  + x5.o <clinit>()
  + x5.o <init>(Throwable)
  + x5.o describeContents() → int
  + x5.o
...✂

@tillh-stripe tillh-stripe changed the base branch from master to tillh/instant-debit-fixes September 12, 2024 18:34
Base automatically changed from tillh/instant-debit-fixes to master September 12, 2024 19:31
@tillh-stripe tillh-stripe force-pushed the tillh/fc-intent-context branch 5 times, most recently from b63d623 to ddc679b Compare September 16, 2024 18:27
@tillh-stripe tillh-stripe changed the title Add IntentContext to FC flows Add ElementsContext to FC flows Sep 16, 2024
@tillh-stripe tillh-stripe changed the title Add ElementsContext to FC flows Add ElementsContext to Instant Debits flows Sep 16, 2024
@tillh-stripe tillh-stripe force-pushed the tillh/fc-intent-context branch 6 times, most recently from f3f3249 to 3195475 Compare September 17, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant