Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial CustomerSheet data sources & use in CustomerSheet #9278

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented Sep 16, 2024

Summary

Add initial CustomerSheet data sources & use in CustomerSheet

Motivation

Starts the move towards separate data sources for CustomerSheet which will allow for an internal CustomerSession implementation.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

github-actions bot commented Sep 16, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   1.9 MiB │   1.9 MiB │  0 B │     4 MiB │     4 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.8 KiB │   6.8 KiB │  0 B │   6.5 KiB │   6.5 KiB │  0 B 
    other │  85.5 KiB │  85.5 KiB │ +9 B │ 158.7 KiB │ 158.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.5 MiB │   9.5 MiB │ +9 B │  21.4 MiB │  21.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20244 │ 20244 │ 0 (+0 -0) 
   types │  6082 │  6082 │ 0 (+0 -0) 
 classes │  4886 │  4886 │ 0 (+0 -0) 
 methods │ 29462 │ 29462 │ 0 (+0 -0) 
  fields │ 17389 │ 17389 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3608 │ 3608 │  0
APK
   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 28.3 KiB │ +6 B │ 62.6 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    272 B │ +4 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │ -1 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 29.8 KiB │ +9 B │ 63.9 KiB │  0 B │ (total)

@samer-stripe samer-stripe force-pushed the samer/customer-sheet-data-source branch 2 times, most recently from 57d7c5c to d97d4a4 Compare September 16, 2024 01:39
Base automatically changed from samer/persist-config-in-view-model to master September 16, 2024 20:54
@samer-stripe samer-stripe changed the title Add CustomerSheetDataSource & CustomerAdapterDataSource. Add CustomerSheetPaymentMethodDataSource & use in CustomerSheet Sep 16, 2024
@@ -153,7 +154,7 @@ class CustomerSheet internal constructor(
onSuccess = {
CustomerSheetResult.Selected(it)
},
onFailure = { cause, _ ->
onFailure = { cause ->
CustomerSheetResult.Failed(cause)
}
)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here are covered by the pre-existing CustomerSheet tests we added recently.

@samer-stripe samer-stripe changed the title Add CustomerSheetPaymentMethodDataSource & use in CustomerSheet Add initial CustomerSheet data sources & use in CustomerSheet Sep 18, 2024
@samer-stripe samer-stripe marked this pull request as ready for review September 18, 2024 16:18
@samer-stripe samer-stripe requested review from a team as code owners September 18, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants