Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use data sources in CustomerSheetViewModel #9281

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented Sep 16, 2024

Summary

Uses CustomerSheetPaymentMethodDataSource and CustomerSheetSavedSelectionDataSource in CustomerSheetViewModel. Also add CustomerSheetIntentDataSource as well.

Motivation

Helps move CustomerSheet to new data source architecture which will allow for CustomerSession to be built into it.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Copy link
Contributor

github-actions bot commented Sep 16, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   1.9 MiB │   1.9 MiB │  0 B │     4 MiB │     4 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   6.8 KiB │   6.8 KiB │  0 B │   6.5 KiB │   6.5 KiB │  0 B 
    other │  85.5 KiB │  85.5 KiB │ +5 B │ 158.7 KiB │ 158.7 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.5 MiB │   9.5 MiB │ +5 B │  21.4 MiB │  21.4 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20244 │ 20244 │ 0 (+0 -0) 
   types │  6082 │  6082 │ 0 (+0 -0) 
 classes │  4886 │  4886 │ 0 (+0 -0) 
 methods │ 29462 │ 29462 │ 0 (+0 -0) 
  fields │ 17389 │ 17389 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3608 │ 3608 │  0
APK
   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
  1.2 KiB │ +2 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
 25.1 KiB │ +2 B │ 62.5 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
    272 B │ +1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 26.5 KiB │ +5 B │ 63.8 KiB │  0 B │ (total)

@samer-stripe samer-stripe force-pushed the samer/customer-sheet-data-source branch 4 times, most recently from 1735da9 to d31e470 Compare September 18, 2024 17:39
@samer-stripe samer-stripe force-pushed the samer/use-data-source-in-cs-view-model branch 2 times, most recently from 5700e0e to 1e36f9b Compare September 20, 2024 08:19
@samer-stripe samer-stripe changed the title Use CustomerSheetDataSource in CustomerSheetViewModel Use data sources in CustomerSheetViewModel Sep 20, 2024
Base automatically changed from samer/customer-sheet-data-source to master September 20, 2024 17:31
@samer-stripe samer-stripe force-pushed the samer/use-data-source-in-cs-view-model branch from 1e36f9b to a15a5c7 Compare September 20, 2024 17:35
customerAdapterProvider = CompletableDeferred(customerAdapter),
paymentMethodDataSourceProvider = dataSourceProvider,
intentDataSourceProvider = dataSourceProvider,
savedSelectionDataSourceProvider = dataSourceProvider,
Copy link
Collaborator Author

@samer-stripe samer-stripe Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have fakes made for each of these in a follow-up PR though can merge into this PR if we feel that is appropriate. I just wanted to verify that the behavior still works as expected with the data sources.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing this in a follow up sgtm!

@samer-stripe samer-stripe marked this pull request as ready for review September 20, 2024 17:57
@samer-stripe samer-stripe requested review from a team as code owners September 20, 2024 17:57
customerAdapterProvider = CompletableDeferred(customerAdapter),
paymentMethodDataSourceProvider = dataSourceProvider,
intentDataSourceProvider = dataSourceProvider,
savedSelectionDataSourceProvider = dataSourceProvider,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing this in a follow up sgtm!

@samer-stripe samer-stripe merged commit 2e97db3 into master Sep 20, 2024
13 checks passed
@samer-stripe samer-stripe deleted the samer/use-data-source-in-cs-view-model branch September 20, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants