-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use data sources in CustomerSheetViewModel
#9281
Conversation
Diffuse output:
APK
|
1735da9
to
d31e470
Compare
5700e0e
to
1e36f9b
Compare
CustomerSheetDataSource
in CustomerSheetViewModel
CustomerSheetViewModel
1e36f9b
to
a15a5c7
Compare
customerAdapterProvider = CompletableDeferred(customerAdapter), | ||
paymentMethodDataSourceProvider = dataSourceProvider, | ||
intentDataSourceProvider = dataSourceProvider, | ||
savedSelectionDataSourceProvider = dataSourceProvider, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have fakes made for each of these in a follow-up PR though can merge into this PR if we feel that is appropriate. I just wanted to verify that the behavior still works as expected with the data sources.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing this in a follow up sgtm!
customerAdapterProvider = CompletableDeferred(customerAdapter), | ||
paymentMethodDataSourceProvider = dataSourceProvider, | ||
intentDataSourceProvider = dataSourceProvider, | ||
savedSelectionDataSourceProvider = dataSourceProvider, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doing this in a follow up sgtm!
Summary
Uses
CustomerSheetPaymentMethodDataSource
andCustomerSheetSavedSelectionDataSource
inCustomerSheetViewModel
. Also addCustomerSheetIntentDataSource
as well.Motivation
Helps move
CustomerSheet
to new data source architecture which will allow forCustomerSession
to be built into it.Testing