Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolu/feat/link card edit #9718

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

toluo-stripe
Copy link
Contributor

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Nov 28, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed          
          ├───────────┬───────────┬──────────┼──────────┬──────────┬──────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff     
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
      dex │   3.9 MiB │   3.9 MiB │ +1.4 KiB │  8.5 MiB │  8.6 MiB │ +3.6 KiB 
     arsc │   2.3 MiB │   2.3 MiB │      0 B │  2.3 MiB │  2.3 MiB │      0 B 
 manifest │     5 KiB │     5 KiB │      0 B │ 24.9 KiB │ 24.9 KiB │      0 B 
      res │ 906.3 KiB │ 906.3 KiB │      0 B │  1.4 MiB │  1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │      0 B 
    asset │   1.6 MiB │   1.6 MiB │     -4 B │  1.6 MiB │  1.6 MiB │     -4 B 
    other │   1.4 MiB │   1.4 MiB │     -7 B │  1.6 MiB │  1.6 MiB │      0 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼──────────
    total │  12.7 MiB │  12.7 MiB │ +1.4 KiB │ 21.6 MiB │ 21.6 MiB │ +3.6 KiB 

 DEX     │ old   │ new   │ diff            
─────────┼───────┼───────┼─────────────────
   files │     1 │     1 │   0             
 strings │ 40496 │ 40512 │ +16 (+37 -21)   
   types │ 13981 │ 13989 │  +8 (+28 -20)   
 classes │ 11663 │ 11669 │  +6 (+6 -0)     
 methods │ 59532 │ 59561 │ +29 (+591 -562) 
  fields │ 39734 │ 39747 │ +13 (+356 -343) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6206 │ 6206 │  0
APK
     compressed      │     uncompressed     │                               
──────────┬──────────┼───────────┬──────────┤                               
 size     │ diff     │ size      │ diff     │ path                          
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  3.9 MiB │ +1.4 KiB │   8.6 MiB │ +3.6 KiB │ ∆ classes.dex                 
  7.8 KiB │     -4 B │   7.7 KiB │     -4 B │ ∆ assets/dexopt/baseline.prof 
 53.4 KiB │     -3 B │ 118.3 KiB │      0 B │ ∆ META-INF/CERT.SF            
  1.2 KiB │     -3 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA           
 50.1 KiB │     -1 B │ 118.3 KiB │      0 B │ ∆ META-INF/MANIFEST.MF        
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
    4 MiB │ +1.4 KiB │   8.8 MiB │ +3.6 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   40496 │ 40512 │ +16 (+37 -21) 
  
  + , collectName=
  + An operation is not implemented.
  + CardBillingSpec(apiPath=
  + CardDetailsSectionSpec(apiPath=
  + LE8/b2;
  + LE8/c2;
  + LE8/d2;
  + LE8/e2;
  + LE8/f2;
  + LE8/g2;
  + [LE8/B1;
  + [LE8/E0;
  + [LE8/F1;
  + [LE8/L0;
  + [LE8/N0;
  + [LE8/P1;
  + [LE8/Q0;
  + [LE8/S1;
  + [LE8/U;
  + [LE8/V0;
  + [LE8/Z1;
  + [LE8/e2;
  + [LE8/f1;
  + [LE8/g2;
  + [LE8/j0;
  + [LE8/k1;
  + [LE8/n1;
  + [LE8/o0;
  + [LE8/r0;
  + [LE8/u1;
  + [LE8/x1;
  + [LE8/y1;
  + card_billing
  + collect_name
  + com.stripe.android.ui.core.elements.CardBillingSpec
  + com.stripe.android.ui.core.elements.CardDetailsSectionSpec
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"0d69998","r8-mode":"full","version":"8.7.14"}
  
  - [LE8/A1;
  - [LE8/F0;
  - [LE8/J1;
  - [LE8/K0;
  - [LE8/P0;
  - [LE8/T1;
  - [LE8/Y1;
  - [LE8/Z0;
  - [LE8/a2;
  - [LE8/b1;
  - [LE8/e1;
  - [LE8/i0;
  - [LE8/l0;
  - [LE8/o1;
  - [LE8/r1;
  - [LE8/s1;
  - [LE8/v0;
  - [LE8/v1;
  - [LE8/y0;
  - [LE8/z1;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"e72f7fa","r8-mode":"full","version":"8.7.14"}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   13981 │ 13989 │ +8 (+28 -20) 
  
  + LE8/b2;
  + LE8/c2;
  + LE8/d2;
  + LE8/e2;
  + LE8/f2;
  + LE8/g2;
  + [LE8/B1;
  + [LE8/E0;
  + [LE8/F1;
  + [LE8/L0;
  + [LE8/N0;
  + [LE8/P1;
  + [LE8/Q0;
  + [LE8/S1;
  + [LE8/U;
  + [LE8/V0;
  + [LE8/Z1;
  + [LE8/e2;
  + [LE8/f1;
  + [LE8/g2;
  + [LE8/j0;
  + [LE8/k1;
  + [LE8/n1;
  + [LE8/o0;
  + [LE8/r0;
  + [LE8/u1;
  + [LE8/x1;
  + [LE8/y1;
  
  - [LE8/A1;
  - [LE8/F0;
  - [LE8/J1;
  - [LE8/K0;
  - [LE8/P0;
  - [LE8/T1;
  - [LE8/Y1;
  - [LE8/Z0;
  - [LE8/a2;
  - [LE8/b1;
  - [LE8/e1;
  - [LE8/i0;
  - [LE8/l0;
  - [LE8/o1;
  - [LE8/r1;
  - [LE8/s1;
  - [LE8/v0;
  - [LE8/v1;
  - [LE8/y0;
  - [LE8/z1;
  

METHODS:

   old   │ new   │ diff            
  ───────┼───────┼─────────────────
   59532 │ 59561 │ +29 (+591 -562) 
  
  + A8.g <init>(boolean, f0, Set, T, p, int)
  + C0.c t(a2, p, p, int)
  + D5.V A(H1, p, p, int)
  + D5.V S(l, S1, e) → ArrayList
  + D5.V T(t, S1) → a
  + D5.V d(boolean, c0, Set, T, p, int)
  + E6.h <init>(j, S1, int, int, boolean, b, int)
  + E8.A1 serializer() → a
  + E8.B0 valueOf(String) → B0
  + E8.B0 values() → B0[]
  + E8.B1 <clinit>()
  + E8.B1 <init>()
  + E8.B1 <init>(int, T)
  + E8.B1 <init>(T)
  + E8.B1 describeContents() → int
  + E8.B1 equals(Object) → boolean
  + E8.B1 hashCode() → int
  + E8.B1 j(Map) → K0
  + E8.B1 toString() → String
  + E8.B1 writeToParcel(Parcel, int)
  + E8.C0 <clinit>()
  + E8.C0 a(d, Object)
  + E8.C0 b() → a[]
  + E8.C0 c(c) → Object
  + E8.C0 d() → h
  + E8.C1 <clinit>()
  + E8.C1 a(d, Object)
  + E8.C1 b() → a[]
  + E8.C1 c(c) → Object
  + E8.C1 d() → h
  + E8.D0 serializer() → a
  + E8.D1 serializer() → a
  + E8.E0 <clinit>()
  + E8.E0 <init>(String, int, String)
  + E8.E0 <init>(String, String)
  + E8.E0 describeContents() → int
  + E8.E0 equals(Object) → boolean
  + E8.E0 hashCode() → int
  + E8.E0 toString() → String
  + E8.E0 writeToParcel(Parcel, int)
  + E8.E1 serializer() → a
  + E8.F0 a(d, Object)
  + E8.F0 b() → a[]
  + E8.F0 c(c) → Object
  + E8.F0 d() → h
  + E8.F1 <clinit>()
  + E8.F1 valueOf(String) → F1
  + E8.F1 values() → F1[]
  + E8.G0 serializer() → a
  + E8.G1 <init>(int, T, F1)
  + E8.G1 <init>(T, F1)
  + E8.H0 <init>(int, T, g2, List)
  + E8.H0 <init>(T, g2, ArrayList)
  + E8.H1 <init>(int, boolean)
  + E8.H1 E() → c
  + E8.H1 e() → g0
  + E8.H1 t(String)
  + E8.I0 <init>(T, String, int)
  + E8.I0 a() → T
  + E8.I0 b() → boolean
  + E8.I0 equals(Object) → boolean
  + E8.I0 g() → U
  + E8.I0 hashCode() → int
  + E8.I0 toString() → String
  + E8.I1 <init>(String, boolean)
  + E8.I1 a() → T
  + E8.I1 b() → boolean
  + E8.I1 c() → g0
  + E8.I1 d() → g0
  + E8.I1 e() → c
  + E8.I1 equals(Object) → boolean
  + E8.I1 hashCode() → int
  + E8.I1 toString() → String
  + E8.J0 <clinit>()
  + E8.J0 a(d, Object)
  + E8.J0 b() → a[]
  + E8.J0 c(c) → Object
  + E8.J0 d() → h
  + E8.J1 <init>(boolean, c, int, int)
  + E8.J1 e(Object, Object) → Object
  + E8.K0 serializer() → a
  + E8.L0 <clinit>()
  + E8.L0 <init>()
  + E8.L0 <init>(int, T)
  + E8.L0 <init>(T)
  + E8.L0 describeContents() → int
  + E8.L0 equals(Object) → boolean
  + E8.L0 hashCo
...✂

@toluo-stripe toluo-stripe force-pushed the tolu/feat/link_card_edit branch from 6330504 to 5df2875 Compare November 29, 2024 21:22
@toluo-stripe toluo-stripe force-pushed the tolu/feat/link_card_edit branch from 5df2875 to 5ab6d28 Compare December 4, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant