Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up #9728

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

clean up #9728

wants to merge 6 commits into from

Conversation

toluo-stripe
Copy link
Contributor

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed           
          ├───────────┬───────────┬──────────┼──────────┬──────────┬───────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff      
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼───────────
      dex │   3.9 MiB │   3.9 MiB │ +7.3 KiB │  8.5 MiB │  8.6 MiB │ +11.1 KiB 
     arsc │   2.3 MiB │   2.3 MiB │   +688 B │  2.3 MiB │  2.3 MiB │    +688 B 
 manifest │     5 KiB │     5 KiB │      0 B │ 24.9 KiB │ 24.9 KiB │       0 B 
      res │ 906.3 KiB │ 906.3 KiB │      0 B │  1.4 MiB │  1.4 MiB │       0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │       0 B 
    asset │   1.6 MiB │   1.6 MiB │ +1.4 KiB │  1.6 MiB │  1.6 MiB │  +1.4 KiB 
    other │   1.4 MiB │   1.4 MiB │     +3 B │  1.6 MiB │  1.6 MiB │       0 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼───────────
    total │  12.7 MiB │  12.7 MiB │ +9.3 KiB │ 21.6 MiB │ 21.6 MiB │ +13.1 KiB 

 DEX     │ old   │ new   │ diff                
─────────┼───────┼───────┼─────────────────────
   files │     1 │     1 │   0                 
 strings │ 40487 │ 40521 │ +34 (+2839 -2805)   
   types │ 13978 │ 13986 │  +8 (+2812 -2804)   
 classes │ 11660 │ 11668 │  +8 (+2233 -2225)   
 methods │ 59512 │ 59557 │ +45 (+23892 -23847) 
  fields │ 39708 │ 39736 │ +28 (+15842 -15814) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  243 │  243 │  0         
 entries │ 6206 │ 6207 │ +1 (+1 -0)
APK
     compressed      │     uncompressed      │                                           
──────────┬──────────┼───────────┬───────────┤                                           
 size     │ diff     │ size      │ diff      │ path                                      
──────────┼──────────┼───────────┼───────────┼───────────────────────────────────────────
  3.9 MiB │ +7.3 KiB │   8.6 MiB │ +11.1 KiB │ ∆ classes.dex                             
  7.8 KiB │ +1.4 KiB │   7.7 KiB │  +1.4 KiB │ ∆ assets/dexopt/baseline.prof             
  2.3 MiB │   +688 B │   2.3 MiB │    +688 B │ ∆ resources.arsc                          
    127 B │   +127 B │       5 B │      +5 B │ + META-INF/services/E9.x                  
    127 B │   +127 B │       5 B │      +5 B │ + META-INF/services/F9.a                  
          │   -127 B │           │      -5 B │ - META-INF/services/D9.x                  
          │   -127 B │           │      -5 B │ - META-INF/services/E9.a                  
    988 B │     -7 B │     856 B │      -7 B │ ∆ assets/dexopt/baseline.profm            
 53.4 KiB │     +5 B │ 118.3 KiB │       0 B │ ∆ META-INF/CERT.SF                        
    271 B │     -1 B │     120 B │       0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │     -1 B │   1.2 KiB │       0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────────┼───────────┼───────────┼───────────────────────────────────────────
  6.3 MiB │ +9.3 KiB │    11 MiB │ +13.1 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
   40487 │ 40521 │ +34 (+2839 -2805) 
  
  + , hasCompleted=
  + Cancel
  + EditCard
  + LA6/A;
  + LA6/B;
  + LA6/u;
  + LA6/v;
  + LA6/w;
  + LA6/x;
  + LA6/y;
  + LA6/z;
  + LA7/m;
  + LA7/n;
  + LA7/o;
  + LA7/p;
  + LA7/q;
  + LA7/r;
  + LA7/s;
  + LA7/t;
  + LAa/c;
  + LAa/d;
  + LAa/e;
  + LAa/f;
  + LAa/g;
  + LAa/h;
  + LAa/i;
  + LAa/j;
  + LB/n0;
  + LB/o0;
  + LB3/c;
  + LB8/a;
  + LB8/b;
  + LB8/c;
  + LB8/d;
  + LB8/e;
  + LB8/f;
  + LB9/A;
  + LB9/f;
  + LB9/g;
  + LB9/h;
  + LB9/i;
  + LB9/j;
  + LB9/k;
  + LB9/l;
  + LB9/m;
  + LB9/n;
  + LB9/o;
  + LB9/p;
  + LB9/q;
  + LB9/r;
  + LB9/s;
  + LB9/t;
  + LB9/u;
  + LB9/v;
  + LB9/w;
  + LB9/x;
  + LB9/y;
  + LB9/z;
  + LC6/A;
  + LC6/d;
  + LC6/e;
  + LC6/f;
  + LC6/g;
  + LC6/h;
  + LC6/i;
  + LC6/j;
  + LC6/k;
  + LC6/l;
  + LC6/m;
  + LC6/n;
  + LC6/o;
  + LC6/p;
  + LC6/q;
  + LC6/r;
  + LC6/s;
  + LC6/t;
  + LC6/u;
  + LC6/v;
  + LC6/w;
  + LC6/x;
  + LC6/y;
  + LC6/z;
  + LC9/b;
  + LC9/c;
  + LC9/d;
  + LC9/e;
  + LD6/b;
  + LD8/b;
  + LD8/c;
  + LDa/d;
  + LDa/e;
  + LDa/f;
  + LE7/m;
  + LE7/n;
  + LE7/o;
  + LE7/p;
  + LE7/q;
  + LE7/r;
  + LE7/s;
  + LE7/t;
  + LE7/u;
  + LE9/A0;
  + LE9/A;
  + LE9/B0;
  + LE9/B;
  + LE9/C0;
  + LE9/C;
  + LE9/D;
  + LE9/E;
  + LE9/F;
  + LE9/G;
  + LE9/H;
  + LE9/I;
  + LE9/J;
  + LE9/K;
  + LE9/L;
  + LE9/M;
  + LE9/N;
  + LE9/O;
  + LE9/P;
  + LE9/Q;
  + LE9/S;
  + LE9/T;
  + LE9/U;
  + LE9/V;
  + LE9/W;
  + LE9/X;
  + LE9/Y;
  + LE9/Z;
  + LE9/a0;
  + LE9/b0;
  + LE9/c0;
  + LE9/d0;
  + LE9/e0;
  + LE9/f0;
  + LE9/f;
  + LE9/g0;
  + LE9/g;
  + LE9/h0;
  + LE9/h;
  + LE9/i0;
  + LE9/i;
  + LE9/j0;
  + LE9/j;
  + LE9/k0;
  + LE9/k;
  + LE9/l0;
  + LE9/l;
  + LE9/m0;
  + LE9/m;
  + LE9/n0;
  + LE9/n;
  + LE9/o0;
  + LE9/o;
  + LE9/p0;
  + LE9/p;
  + LE9/q0;
  + LE9/q;
  + LE9/r0;
  + LE9/r;
  + LE9/s0;
  + LE9/s;
  + LE9/t0;
  + LE9/t;
  + LE9/u0;
  + LE9/u;
  + LE9/v0;
  + LE9/v;
  + LE9/w0;
  + LE9/w;
  + LE9/x0;
  + LE9/x;
  + LE9/y0;
  + LE9/y;
  + LE9/z0;
  + LE9/z;
  + LF8/A0;
  + LF8/A1;
  + LF8/A;
  + LF8/B0;
  + LF8/B1;
  + LF8/B;
  + LF8/C0;
  + LF8/C1;
  + LF8/C;
  + LF8/D0;
  + LF8/D1;
  + LF8/D;
  + LF8/E0;
  + LF8/E1;
  + LF8/E;
  + LF8/F0;
  + LF8/F1;
  + LF8/F;
  + LF8/G0;
  + LF8/G1;
  + LF8/G;
  + LF8/H0;
  + LF8/H1;
  + LF8/H;
  + LF8/I0;
  + LF8/I1;
  + LF8/I;
  + LF8/J0;
  + LF8/J1;
  + LF8/J;
  + LF8/K0;
  + LF8/K1;
  + LF8/K;
  + LF8/L0;
  + LF8/L1;
  + LF8/L;
  + LF8/M0;
  + LF8/M1;
  + LF8/M;
  + LF8/N0;
  + LF8/N1;
  + LF8/N;
  + LF8/O0;
  + LF8/O1;
  + LF8/O;
  + LF8/P0;
  + LF8/P1;
  + LF8/P;
  + LF8/Q0;
  + LF8/Q1;
  + LF8/Q;
  + LF8/R0;
  + LF8/R1;
  + LF8/S0;
  + LF8/S1;
  + LF8/S;
  + LF8/T0;
  + LF8/T1;
  + LF8/T;
  + LF8/U0;
  + LF8/U1;
  + LF8/U;
  + LF8/V0;
  + LF8/V1;
  + LF8/V;
  + LF8/W0;
  + LF8/W1;
  + LF8/W;
  + LF8/X0;
  + LF8/X1;
  + LF8/X;
  + LF8/Y0;
  + LF8/Y1;
  + LF8/Y;
  + LF8/Z0;
  + LF8/Z1;
  + LF8/Z;
  + LF8/a0;
  + LF8/a1;
  + LF8/b0;
  + LF8/b1;
  + LF8/c0;
  + LF8/c1;
  + LF8/d0;
  + LF8/d1;
  + LF8/e0;
  + LF8/e1;
  + LF8/e;
  + LF8/f0;
  + LF8/f1;
  + LF8/f;
  + LF8/g0;
  + LF8/g1;
  + LF8/g;
  + LF8/h0;
  + LF8/h1;
  + LF8/h;
  + LF8/i0;
  + LF8/i1;
  + LF8/i;
  + LF8/j0;
  + LF8/j1;
  + LF8/j;
  + LF8/k0;
  + LF8/k1;
  + LF8/k;
  + LF8/l0;
  + LF8/l1;
  + LF8/l;
  + LF8/m0;
  + LF8/m1;
  + LF8/m;
  + LF8/n0;
  + LF8/n1;
  + LF8/n;
  + LF8/o0;
  + LF8/o1;
  + LF8/o;
  + LF8/p0;
  + LF8/p1;
  + LF8/p;
  + LF8/q0;
  + LF8/q1;
  + LF8/q;
  + LF8/r0;
  + LF8/r1;
  + LF8/r;
  + LF8/s0;
  + LF8/s1;
  + LF8/s;
  + LF8/t0;
  + LF8/t1;
  + LF8/t;
  + LF8/u0;
  + LF8/u1;
  + LF8/u;
  + LF8/v0;
  + LF8/v1;
  + LF8/v;
  + LF8/w0;
  + LF8/w1;
  + LF8/w;
  + LF8/x0;
  + LF8/x1;
  + LF8/x;
  + LF8/y0;
  + LF8/y1;
  + LF8/y;
  + LF8/z0;
  + LF8/z1;
  + LF8/z;
  + LFa/d;
  + LFa/e;
  + LG2/h;
  + LG7/A;
  + LG7/B;
  + LG7/C;
  + LG7/D;
  + LG7/E;
  + LG7/F;
  + LG7/k;
  + LG7/l;
  + LG7/m;
  + LG7/n;
  + LG7/o;
  + LG7/p;
  + LG7/q;
  + LG7/r;
  + LG7/s;
  + LG7/t;
  + LG7/u;
  + LG7/v;
  + LG7/w;
  + LG7/x;
  + LG7/y;
  + LG7/z;
  + LH6/A;
  + LH6/B;
  + LH6/C;
  + LH6/D;
  + LH6/E;
  + LH6/F;
  + LH6/G;
  + LH6/H;
  + LH6/I;
  + LH6/J;
  + LH6/K;
  + LH6/L;
  + LH6/M;
  + LH6/N;
  + LH6/O;
  + LH6/c;
  + LH6/d;
  + LH6/e;
  + LH6/f;
  + LH6/g;
  + LH6/h;
  + LH6/i;
  + LH6/j;
  + LH6/k;
  + LH6/l;
  + LH6/m;
  + LH6/n;
  + LH6/o;
  + LH6/p;
  + LH6/q;
  + LH6/r;
  + LH6/s;
  + L
...✂
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6206 │ 6207 │ +1 (+1 -0) 
  + string/stripe_wallet_remove_card

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant