Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FC] Sends supports_app_verification to sync call when Integrity available #9819

Draft
wants to merge 1 commit into
base: carlosmuvi/12-21-prepares_integrity_on_first_sync_call
Choose a base branch
from

Conversation

carlosmuvi-stripe
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe commented Dec 21, 2024

Summary

Passes app verification support to sync via new parameters supports_app_verification and verified_app_id.

Motivation

https://docs.google.com/document/d/1joKz5UZHLVazmecfMHbq6gB6n4wj5u8To6AtqYgq_tc/edit?tab=t.0#heading=h.cz1xkpga7giy

Testing

  • Modified tests
  • Manually verified

@carlosmuvi-stripe
Copy link
Collaborator Author

carlosmuvi-stripe commented Dec 21, 2024

@carlosmuvi-stripe carlosmuvi-stripe changed the title Sends supports_app_verification to syncrhonize when Integrity available Add app verification support to Financial Connections Dec 21, 2024
@carlosmuvi-stripe carlosmuvi-stripe changed the title Add app verification support to Financial Connections Adds Dec 21, 2024
@carlosmuvi-stripe carlosmuvi-stripe changed the title Adds Sends supports_app_verification to sync call when Integrity available Dec 21, 2024
Copy link
Contributor

github-actions bot commented Dec 21, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ +1 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +1 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19970 │ 19970 │ 0 (+0 -0) 
   types │  6191 │  6191 │ 0 (+0 -0) 
 classes │  4982 │  4982 │ 0 (+0 -0) 
 methods │ 29769 │ 29769 │ 0 (+0 -0) 
  fields │ 17540 │ 17540 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
   compressed    │  uncompressed   │                                           
──────────┬──────┼──────────┬──────┤                                           
 size     │ diff │ size     │ diff │ path                                      
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 28.4 KiB │ +2 B │ 62.9 KiB │  0 B │ ∆ META-INF/CERT.SF                        
    271 B │ -1 B │    120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼──────┼──────────┼──────┼───────────────────────────────────────────
 28.7 KiB │ +1 B │   63 KiB │  0 B │ (total)

@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available branch 2 times, most recently from 5da26c9 to ecc939b Compare December 23, 2024 10:41
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-prepares_integrity_on_first_sync_call branch from dae2c69 to 706894d Compare December 23, 2024 10:47
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available branch from ecc939b to 30a830a Compare December 23, 2024 10:47
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-prepares_integrity_on_first_sync_call branch from 706894d to 04b27ef Compare December 23, 2024 11:52
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available branch from 30a830a to b87210e Compare December 23, 2024 11:52
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-prepares_integrity_on_first_sync_call branch from 04b27ef to 69c825d Compare December 23, 2024 12:03
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available branch from b87210e to b2bb731 Compare December 23, 2024 12:04
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-prepares_integrity_on_first_sync_call branch from 69c825d to 1f9ede2 Compare December 23, 2024 12:12
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available branch from b2bb731 to c053783 Compare December 23, 2024 12:12
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-prepares_integrity_on_first_sync_call branch from 1f9ede2 to f49fde3 Compare December 23, 2024 12:17
@carlosmuvi-stripe carlosmuvi-stripe changed the title Sends supports_app_verification to sync call when Integrity available [FC] Sends supports_app_verification to sync call when Integrity available Dec 23, 2024
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available branch from c053783 to 03c604c Compare December 23, 2024 12:17
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-prepares_integrity_on_first_sync_call branch from a153a66 to 1840272 Compare December 23, 2024 14:26
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available branch from 03c604c to eed6066 Compare December 23, 2024 14:27
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-prepares_integrity_on_first_sync_call branch from 1840272 to ef32d6f Compare December 23, 2024 14:28
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available branch from eed6066 to ade027d Compare December 23, 2024 14:28
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-prepares_integrity_on_first_sync_call branch from ef32d6f to 8b718ff Compare December 24, 2024 13:08
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available branch 2 times, most recently from 60ad1f8 to 6ff391a Compare December 24, 2024 15:26
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-prepares_integrity_on_first_sync_call branch from 9be7b86 to 67af8e1 Compare December 25, 2024 11:00
@carlosmuvi-stripe carlosmuvi-stripe force-pushed the carlosmuvi/12-21-sends_supports_app_verification_to_syncrhonize_when_integrity_available branch from 6ff391a to 92d3005 Compare December 25, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant