Remove special case Newtonsoft version, and update TargetFrameworks #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… builds for those targets suppressed an obsolete warning in net8.0 (safe for now, will take care of later) updated StripeNetTargetFramework string building in SystemNetHttpClient
helenye-stripe
approved these changes
Oct 3, 2024
ramya-stripe
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We upgraded Newtonsoft and aimed to remove all of the per-target special cases in #2930 but we missed net8.0. As a result, Stripe.net v46 still requires a
[bindingRedirect](https://learn.microsoft.com/en-us/dotnet/framework/configure-apps/file-schema/runtime/bindingredirect-element)to use the latest Newtonsoft.Json version. This was not caught because net8.0 was not listed as a target framework in the csproj file. This PR both removes the Newtonsoft.Json special case and adds net8.0 (and net7.0) to the TargetFrameworks tag to ensure they are included in our automated checks.What?
StripeNetTargetFrameworkinSystemNetHttpClientto include these versions