Use pinned version of tools in Makefile and ci.yml #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathmesh-stripe
approved these changes
Sep 9, 2024
jar-stripe
changed the title
jar-stripe
added a commit
that referenced
this pull request
Sep 9, 2024
* pinned the tools version in Makefile for codegen-format step * changed tools version to v0.24.0 in ci yml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
go tools new release requires a later version of go than what we support. Use of @latest in the Makefile and ci.yml file causes us to always fetch the latest which will cause CI builds to fail.
Changes:
changed Makefile codegen format to install tools v0.24.0 (which is the last version before the breaking change) instead of latest
changed ci.yml in linter step to use v0.24.0 instead of latest