Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you tap a saved PM, Apple Pay, or Link, PaymentSheet no longer s… #3438

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

yuki-stripe
Copy link
Collaborator

@yuki-stripe yuki-stripe commented Mar 20, 2024

…ets it as the default. They are only set as the default after you successfully confirm.

TODO: Set default for saved PMs, saved Link, Apple Pay?

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-1855

Testing

We didn't have tests for the removed behavior.
There is a test for the remaining behavior where new PMs are set after successful confirms.
TODO: Add tests for Link, Apple Pay, saved PMs?

Changelog

  • [Changed] Tapping a saved PM/Apple Pay/Link no longer sets it as the default; they are only set as the default after you successfully confirm.

@yuki-stripe yuki-stripe requested review from a team as code owners March 20, 2024 18:37
@yuki-stripe yuki-stripe marked this pull request as draft March 20, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant