feat: migrate to picoquery #2146
Conversation
Migrates from qs to picoquery for query strings, a faster and lighter alternative.
|
|
|
|
| @@ -3,6 +3,7 @@ | |||
| "compilerOptions": { | |||
| "outDir": "./esm", | |||
| "module": "es2022", | |||
| "moduleResolution": "node", | |||
There was a problem hiding this comment.
locally the esm tsc build failed without this. i'm not sure how it ever worked without it 🤔
There was a problem hiding this comment.
We have been using the default and have not had issues, could you pull this out of this PR?
|
Hi @43081j, thanks so much for this submission! Sorry for the delay. I think after reviewing the approaches for removing qs, we would like to investigate this further. Would you mind investigating the test failure here? |
|
unfortunately this is because node 12 doesn't support nullish coalescing bumping the engine constraint here (i.e. dropping node <14 support) seems the sensible thing to do eventually but that seems like a bigger decision for you to make until then i guess this PR is blocked let me know what you think. if we have to hold off until node <14 support is dropped one day, im happy to come back at that point and revisit this |
|
Yes, our version support policy is something we're working on. We'll put a pin in this and merge it when we can drop node 12 support. Thank you for your contribution! |
Migrates from qs to picoquery for query strings, a faster and lighter alternative.
This is an alternative to #2116 - using pq to provide the logic rather than rolling our own. We are doing the same in storybook and many other repos, so figured it'd be worth doing so here too.
if you'd prefer to roll your own, feel free to close this