Add AbortSignal support #2240
Closed
Add AbortSignal support #2240
+85
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jar-stripe
requested review from
jar-stripe
and removed request for
prathmesh-stripe
|
Hi @fedyk, thanks for submitting this! Is there a corresponding Github issue for this PR, and if not would you mind creating one? We vet additions to the SDK's public interface very carefully so having as much context as possible helps us understand the goal and impact of your change. Thanks again! |
|
@jar-stripe, here is an issue where I tried to describe the context behind the changes. Please let me know if something is not clear or need more details. |
|
Unable to accept this PR as written as it relies on functionality introduced in Node v14. This is worth revisiting once we retire Node v12 support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
AbortSignal: