Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMake options ENABLE_DECODER and ENABLE_ENCODER #331

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

heitbaum
Copy link
Contributor

@heitbaum heitbaum commented Sep 4, 2022

Update make to allow build with/without Decoder or Encoder.
Default to building (as-is currently the case)

@heitbaum
Copy link
Contributor Author

@farindk - updated the PR to match your 296130f commit. Tested with 1.0.9.

@farindk farindk merged commit 2b5dedd into strukturag:master Oct 20, 2022
@farindk
Copy link
Contributor

farindk commented Oct 20, 2022

Thank you.

@heitbaum heitbaum deleted the cmake branch October 20, 2022 21:35
@fancycode
Copy link
Member

@farindk this broke the windows CI which is expecting the enc265.exe to exist:

- copy /y build\enc265\%CONFIGURATION%\enc265.exe build

Example failure: https://ci.appveyor.com/project/strukturag/libde265/build/job/86sp8krn9hvr50ht

@farindk
Copy link
Contributor

farindk commented Jan 25, 2023

@fancycode Can we exclude enc265.exe from the Windows CI? The encoder is not in a usable state, nobody is using it, and that probably won't change anytime soon.

@fancycode
Copy link
Member

Fix for Windows CI is in #389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants