Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two small typos in gt4py branch #1

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

gvollenweider
Copy link
Collaborator

Changes qsfg variable back to qs as in original fortran code.
Changes filename in @ported_function from cloudsc2.f90 back to cloudsc.f90.

Copy link
Owner

@stubbiali stubbiali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for spotting these typos @gvollenweider! Please merge.

@gvollenweider
Copy link
Collaborator Author

I don't think I have the rights to merge. 🤷🏽‍♂️
It seems like you need to merge?

@stubbiali
Copy link
Owner

You're right, I had to add you as a collaborator. Now you should be able to merge yourself.

@gvollenweider
Copy link
Collaborator Author

gvollenweider commented Feb 17, 2024

Thanks for adding me as a collaborator!
Before merging I ran the checks, and there are two issues:

  1. The --with-loki runs fail during configuration with:
CMake Error at ecbuild/cmake/ecbuild_log.cmake:190 (message):
  CRITICAL - loki_transform_transpile() was removed!

  Please use

      loki_transform( COMMAND convert [...] )

  or

      loki_transform_target( COMMAND convert [...] ).

  
Call Stack (most recent call first):
  loki/cmake/loki_transform.cmake:455 (ecbuild_critical)
  cloudsc-dwarf/src/cloudsc_loki/CMakeLists.txt:662 (loki_transform_transpile)
  1. The --single-precision runs fail during the build stage with
[Loki::Scheduler] Applied transformation <DrHookTransformation> in 0.00s
[Loki::Scheduler] Applied transformation <SanitiseTransformation> in 0.00s
Traceback (most recent call last):
  File "../../../loki/loki_env/bin/loki-transform.py", line 11, in <module>
    sys.exit(cli())
  File "/home/runner/work/dwarf-p-cloudsc/dwarf-p-cloudsc/build/loki/loki_env/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/home/runner/work/dwarf-p-cloudsc/dwarf-p-cloudsc/build/loki/loki_env/lib/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/home/runner/work/dwarf-p-cloudsc/dwarf-p-cloudsc/build/loki/loki_env/lib/python3.8/site-packages/click/core.py", line 1688, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/runner/work/dwarf-p-cloudsc/dwarf-p-cloudsc/build/loki/loki_env/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/runner/work/dwarf-p-cloudsc/dwarf-p-cloudsc/build/loki/loki_env/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/home/runner/work/dwarf-p-cloudsc/dwarf-p-cloudsc/build/loki/loki_env/lib/python3.8/site-packages/scripts/loki_transform.py", line 206, in convert
    eliminate_dead_code=eliminate_dead_code, allowed_aliases=horizontal.index
AttributeError: 'NoneType' object has no attribute 'index'

Should we merge anyway, and solve these later? Or should I try to solve them now, and only merge when all checks are green?

@gvollenweider gvollenweider merged commit 8705224 into stubbiali:gt4py Feb 19, 2024
3 of 15 checks passed
@gvollenweider gvollenweider deleted the fix-typos branch February 19, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants