Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip642149 #440

Merged
merged 2 commits into from
Feb 7, 2023
Merged

Wip642149 #440

merged 2 commits into from
Feb 7, 2023

Conversation

vuvanhieu143
Copy link
Contributor

Hi @timhunt ,

  • I have fixed two issues:
  • commit 1 is adding the new default sorting for the view.
    Because we have to change the sort order, I need to update the behat to the correct order in tests/behat/pagination.feature
    During testing, we found out that the pinned question is not working as expected
    so I also fix that and add the behat test for that case as well.
    and due to MDL-75337, we can't use the bool variable for the single button anymore, so I change it to primary so that we can pass the CI in master branch.
    the reason I didn't use the constant variable is that the constant didn't exist in 4.0 and 4.1

  • commit 2 to fix this issue.
    Error on delete_orphaned_questions schedulded task execution #438
    and I have added a unit test for that case as well.
    During testing, I found out the test test_create_rate is not making any sense, so I have updated it as well.

Could you please peer review the changes?

@timhunt timhunt merged commit 09b5b5a into studentquiz:main Feb 7, 2023
@timhunt
Copy link
Member

timhunt commented Feb 7, 2023

Thanks. Looks good. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants