Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @timhunt ,
commit 1 is adding the new default sorting for the view.
Because we have to change the sort order, I need to update the behat to the correct order in tests/behat/pagination.feature
During testing, we found out that the pinned question is not working as expected
so I also fix that and add the behat test for that case as well.
and due to MDL-75337, we can't use the bool variable for the single button anymore, so I change it to primary so that we can pass the CI in master branch.
the reason I didn't use the constant variable is that the constant didn't exist in 4.0 and 4.1
commit 2 to fix this issue.
Error on delete_orphaned_questions schedulded task execution #438
and I have added a unit test for that case as well.
During testing, I found out the test test_create_rate is not making any sense, so I have updated it as well.
Could you please peer review the changes?