Drhuffman12 update stumpy bmp #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(1/1 failure => 51/60 failures)
…(avoid pull-rate limits and test across OS's)
… reading tests, add some place-holder tests for the various methods
…e-use; code cleanup
…ed on wikipedia, adjust specs and decoding logic
Drhuffman12 update stumpy bmp (fork-internal)
* drhuffman12_update_stumpy_bmp_part_2 code cleanup * drhuffman12_update_stumpy_bmp_part_2 re-add original example image as 'spec/stumpy_bmp/example/example1/image.bmp' * drhuffman12_update_stumpy_bmp_part_2 re-add '.travis.yml' file (for comparison and in case they want to keep it) * drhuffman12_update_stumpy_bmp_part_2 add 3rd example image (3wx7h w/ transparency, so 32 bbp) * drhuffman12_update_stumpy_bmp_part_2 add 'SHARDS_OPTS=--ignore-crystal-version' to travis config * drhuffman12_update_stumpy_bmp_part_2 Adjust to handle 32 (bgra) vs 24 (bgr) bits per pixel * drhuffman12_update_stumpy_bmp_part_2 add 'example2' tests and split generic tests from 'example0' tests * drhuffman12_update_stumpy_bmp_part_2 code cleanup * drhuffman12_update_stumpy_bmp_part_2 add 'file_data_spec.cr' and update 'bmp_spec.cr' for original image * drhuffman12_update_stumpy_bmp_part_2 code cleanup; prep for tests re remaining methods * drhuffman12_update_stumpy_bmp_part_2 'StumpyCore::Canvas' vs 'Canvas'
|
Very nice, thanks! I'm not programming in crystal anymore but if @sol-vin is ok with it, I can add you as a maintainer for this repo. |
|
My bad, totally fine with me! |
|
Thanks! :) My next step would be to add method(s) for writing bmp files, at least supporting the 24bit rgb and 32bit rgba that I added tests for via this pr. See: drhuffman12#5 . |
|
Also, can we get a Release bump? Thanks. |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This replaces #3
As of commit drhuffman12@6d90cf3:
stumpy_bmpas-is and tried to run the specs (using Crystal 1.0+). The specs wouldn't run; instead I got errors. (See Not working on Crystal 1+ #4)docs, added another test image, switched the tests over to Spectator, etc. You can keep or ignore these additional changes if you want as you see fit.Any suggestions for why the the pixel color tests are not matching up? If not, I can work thru adding tests for the split-up methods.
My goal is to have:
(a) This shard working on Windows, Mac, and Linux .. and with Crystal 1+ ...
(b) All the specs passing
(c) Add some
writemethods (so that I can use it for https://github.com/drhuffman12/crystal_ray_tracer and maybe also for https://github.com/edin/raytracer)It is at least running on all 3 OS's, so that much is good; next we need to get it to pass the specs. Then, add some
writemethods (see #2).