Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature turbo interfaces #2349

Open
wants to merge 72 commits into
base: develop
Choose a base branch
from

Conversation

joshkellyjak
Copy link
Contributor

Proposed Changes

There were some merge issues in the previous pull request that were causing lots of issues in #2209. Hopefully this is resolved here.

Update to the interface initialisation to enable both mixing plane and sliding interfaces within the same turbomachinery simulation. Addition of mass flow outlet to Giles BC.

Related Work

This issue solves a problem reported by a number of users, when simulating radial turbomachinery cases a second-order accurate solution cannot be achieved in some cases when using mixing plane interfaces. This is due to circumfrential averaging in regions where the flow exhibits large circumfrential nonuniformity and/or interspace gaps between adjacent blade-rows/zones small. This issue has been reported by @LorenzoFabris, in a presentation at the SU2 Conference 2022 "Performance Analysis and Shape Optimization of a Radial Compressor with the Open-Source Software SU2" and by myself.

Mass flow outlet included in the PR as requested by users.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

joshkellyjak and others added 30 commits February 8, 2024 16:11
@joshkellyjak
Copy link
Contributor Author

OK this looks to have solved the merge issues, thanks again @bigfooted @jblueh. Still to do is include the testcase I showed in the developer meetings and update the regression tests due to the bug fix in the mixing plane.

Common/include/CConfig.hpp Show resolved Hide resolved
Common/include/option_structure.hpp Outdated Show resolved Hide resolved
Common/include/option_structure.inl Show resolved Hide resolved
Common/src/CConfig.cpp Show resolved Hide resolved
SU2_CFD/include/interfaces/CInterface.hpp Outdated Show resolved Hide resolved
SU2_CFD/include/interfaces/CInterface.hpp Outdated Show resolved Hide resolved
SU2_CFD/src/solvers/CEulerSolver.cpp Outdated Show resolved Hide resolved
@pcarruscag pcarruscag changed the title [WIP] Feature turbo interfaces Feature turbo interfaces Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants