Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

chore: Use default openssl on github CI and do not fail early on tests #805

Merged
merged 1 commit into from
Feb 8, 2024
Merged

chore: Use default openssl on github CI and do not fail early on tests #805

merged 1 commit into from
Feb 8, 2024

Conversation

jsantell
Copy link
Contributor

@jsantell jsantell commented Feb 1, 2024 •
edited
Loading

Installing openssl via choco downloads an exe from slproweb.com:

openssl v3.2.0 [Approved]
openssl package files install completed. Performing other installation steps.
Attempt to get headers for https://slproweb.com/download/Win64OpenSSL-3_2_0.exe failed.
  The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://slproweb.com/download/Win64OpenSSL-3_2_0.exe'. Exception calling "GetResponse" with "0" argument(s): "The remote server returned an error: (404) Not Found."
Downloading openssl 64 bit
  from 'https://slproweb.com/download/Win64OpenSSL-3_2_0.exe'

Occasionally this site goes down. Other times it downloads the 200MB artifact @ 150kb/s, timing out the test. Attempt to use openssl built into GH runners.

@jsantell jsantell mentioned this pull request Feb 1, 2024
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 1, 2024 •
edited
Loading

Test flake analysis

status platform features toolchain
🟢 windows-latest test-kubo,headers stable
🟢 macos-13 test-kubo,headers stable
🟡 macos-13 test-kubo,headers,rocksdb stable
🟡 ubuntu-latest test-kubo,headers stable
🟢 ubuntu-latest test-kubo,headers,rocksdb stable

Flake summary for macos-13, test-kubo,headers,rocksdb, stable

     Summary [ 129.792s] 176 tests run: 176 passed (1 flaky), 1 skipped
   FLAKY 2/5 [  46.361s] noosphere::distributed_stress latency::clients_can_sync_when_there_is_a_lot_of_content

Flake summary for ubuntu-latest, test-kubo,headers, stable

     Summary [  41.727s] 177 tests run: 177 passed (1 flaky), 1 skipped
   FLAKY 2/5 [   3.022s] noosphere-gateway worker::syndication::tests::it_advances_syndication_checkpoint_lifetime_with_clock_time

@jsantell jsantell requested a review from cdata February 1, 2024 19:54
@jsantell jsantell marked this pull request as ready for review February 1, 2024 19:54
@jsantell jsantell changed the title chore: Use default openssl on github CI rather than use slow/intermittent choco distribution chore: Use default openssl on github CI and do not fail early on tests Feb 6, 2024
@jsantell
Copy link
Contributor Author

jsantell commented Feb 6, 2024

Also add CI improvements to continue testing if encountering an error from #796

@jsantell
chore: Update CI with a few features:
f646500 
* Use default openssl on github CI rather than use slow/intermittent choco distribution.
* Do not fail fast (nextest) on CI, and continue running tests if any job within run-test-suites fails.
@jsantell
Copy link
Contributor Author

jsantell commented Feb 7, 2024

Added continue on error to lint tasks as well

cdata
cdata approved these changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdata cdata merged commit ecbf94c into main Feb 8, 2024
20 of 22 checks passed
@cdata cdata deleted the use-gh-openssl branch February 8, 2024 18:58
@jsantell jsantell mentioned this pull request Feb 8, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdata cdata cdata approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsantell @cdata