Skip to content
This repository has been archived by the owner on Sep 21, 2024. It is now read-only.

feat: Roll noosphere-ucan-key-support into noosphere-ucan, replace ed25519-zebra with ed25519-dalek. #840

Merged
merged 1 commit into from
Mar 1, 2024
Merged

feat: Roll noosphere-ucan-key-support into noosphere-ucan, replace ed25519-zebra with ed25519-dalek. #840

merged 1 commit into from
Mar 1, 2024

Conversation

jsantell
Copy link
Contributor

@jsantell jsantell commented Feb 28, 2024 •
edited
Loading

  • Roll noosphere-ucan-key-support into noosphere-ucan under feature flags: ed25519, rsa, p256 and web-rsa
    • ed25519 enabled (indirectly) in tests, replacing the outdated did-key (pulling in an old version of ed25519-dalek with a vuln, though used only in tests).
    • Add all features in CI tests
  • Replace ed25519-zebra with ed25519-dalek.
  • Replace log dependency with tracing.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024 •
edited
Loading

Test flake analysis

status platform features toolchain
🟡 windows-latest test-kubo,headers stable
🟢 ubuntu-latest test-kubo,headers,rocksdb stable
🟢 ubuntu-latest test-kubo,headers stable
🟢 macos-13 test-kubo,headers stable
🟢 macos-13 test-kubo,headers,rocksdb stable
🟡 ubuntu-latest test-kubo,headers nightly

Flake summary for windows-latest, test-kubo,headers, stable

     Summary [  53.844s] 209 tests run: 209 passed (1 flaky), 2 skipped
   FLAKY 2/5 [   5.181s] noosphere::distributed_basic gateway_publishes_and_resolves_petnames_configured_by_the_client

Flake summary for ubuntu-latest, test-kubo,headers, nightly

     Summary [  54.989s] 210 tests run: 210 passed (1 flaky), 2 skipped
   FLAKY 2/5 [  28.520s] noosphere::distributed_stress multiplayer::orb_can_render_peers_in_the_sphere_address_book

@jsantell jsantell force-pushed the ed25519-dalek-ucan branch 5 times, most recently from 3dfb8c7 to 50771f6 Compare February 29, 2024 23:05
@jsantell jsantell marked this pull request as ready for review February 29, 2024 23:05
@jsantell jsantell requested a review from cdata February 29, 2024 23:06
@jsantell jsantell changed the title chore: Replace ed25519-zebra with ed25519-dalek. feat: Roll noosphere-ucan-key-support into noosphere-ucan, replace ed25519-zebra with ed25519-dalek. Feb 29, 2024
cdata
cdata previously approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@cdata cdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsantell jsantell force-pushed the ed25519-dalek-ucan branch 2 times, most recently from 1ea675f to ba7f1b8 Compare March 1, 2024 17:56
@jsantell
feat: Move "noosphere-ucan-key-support" features into "noosphere-ucan…
c1615e7 
…" under feature flags, replace ed25519-zebra with ed25519-dalek.
@jsantell jsantell merged commit 78a4056 into main Mar 1, 2024
22 checks passed
@jsantell jsantell deleted the ed25519-dalek-ucan branch March 1, 2024 18:12
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cdata cdata cdata left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsantell @cdata