This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Log key activities in SQLite #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordonbrander
suggested changes
Jan 13, 2024
| @@ -1371,9 +1372,27 @@ final class DatabaseService { | |||
| }) | |||
| .first | |||
| } | |||
|
|
|||
| func writeActivity<Data: Codable>(event: ActivityEvent<Data>) throws { | |||
There was a problem hiding this comment.
Let's add a test for this method using in-memory SQL
| metadata TEXT DEFAULT '{}' NOT NULL, | ||
| created TEXT DEFAULT CURRENT_TIMESTAMP NOT NULL | ||
| ); | ||
| """ |
There was a problem hiding this comment.
Is it possible to also add a test for these migrations using a fresh in-memory SQL DB? This is a question. I don't recall if I put together the code to make that work.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying not to over engineer anything here.
activitySQLite tableAs mentioned above, this is a step towards offering more sophisticated behaviour in the Deck view over multiple sessions but it could also let us offer an "activity" view in the app where you can see updates like "
@gordonpublished 4 notes".Screen.Recording.2024-01-10.at.12.21.16.pm.mov