Implement Modal Editor Sheet #1141
Conversation
|
|
||
| var background = Color.background | ||
| var color = Color.accentColor |
There was a problem hiding this comment.
Allow theming the keyboard toolbar to match content
| import Combine | ||
|
|
||
| // MARK: View | ||
| struct EditorModalSheetDetailView: View { |
There was a problem hiding this comment.
I forked the existing EditorDetailView for the modal sheet, it's powered by the same underlying model.
When we're ready to cut over we can flatten this out and remove the unused features.
| } | ||
| } | ||
|
|
||
| struct EditorModalSheetModel: ModelProtocol, Equatable { |
There was a problem hiding this comment.
This is a very thin model, I imagine it will merge with the main editor model in the future.
| EdgeInsets( | ||
| top: DeckTheme.cardPadding, | ||
| leading: DeckTheme.cardPadding, | ||
| bottom: 2 * DeckTheme.cardPadding, |
There was a problem hiding this comment.
Space for the "swipe up" system bar
| if app.state.isModalEditorEnabled { | ||
| app.send(.editorSheet(.editEntry(entry))) | ||
| } else { |
There was a problem hiding this comment.
If the setting is enabled notes edited from the notebook will launch in the sheet.
There was a problem hiding this comment.
LGTM as a first pass.
Before unflagging, I'd like us to do some visual/UX refinements
- Refining spacing of header
- Match the spacing of the native sliding panels header
- We could make this a re-usable SwiftUI view
- Use disc style for close button, ensure we match native dimensions
- At one point we had a view for this. Maybe still do?
- Auto-focus editor
- ideally on the character position, or at least the block that is tapped in view-mode
- Refine Post/save flow
- I think we want to have something similar to a social media sheet.
- When you create a new note (draft), header says "post".
- If you exit, the note is saved as a draft
- We may want to introduce an ephemeral draft state with a nag for "discard changes" or "save draft" to simplify mental model.
- If you hit "post", the note is published.
- After a note is published, the button changes to "save"
- If we introduce the save nag, exiting would say "Discard changes? Yes/cancel"
Let me know if dropping into figma would make these notes clearer.
xcode/Subconscious/Shared/Components/Notebook/NotebookNavigationView.swift
Show resolved
Hide resolved
|
@gordonbrander Just FYI, as part of this PR I've addressed:
and, RE: Refine Post/save flow, I believe it already works the way you're describing with the additional layer of "Save" only appears when there are currently unsaved changes to a public note. |
bfollington
force-pushed
the
2024-03-04-modal-editor
branch
from
6e3899f
to
0f61097
Compare
Fixes #1057
Preserves existing editor as-is unless the Developer Setting is enabled.
Next up: integrate into all views / contexts.
Tasks
Screen.Recording.2024-03-22.at.11.52.58.AM.mov