-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
xcode/Subconscious/Shared/Components/FirstRun/FirstRunView.swift
Outdated
Show resolved
Hide resolved
xcode/Subconscious/Shared/Components/FirstRun/FirstRunView.swift
Outdated
Show resolved
Hide resolved
xcode/Subconscious/Shared/Components/FirstRun/FirstRunView.swift
Outdated
Show resolved
Hide resolved
xcode/Subconscious/Shared/Components/Settings/SettingsView.swift
Outdated
Show resolved
Hide resolved
The graphic in the issue is great. We could consider creating a |
xcode/Subconscious/Shared/Components/Common/Forms/ValidatedTextField.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments. Otherwise, LGTM!
xcode/Subconscious/Shared/Components/FirstRun/FirstRunView.swift
Outdated
Show resolved
Hide resolved
xcode/Subconscious/Shared/Components/FirstRun/FirstRunView.swift
Outdated
Show resolved
Hide resolved
xcode/Subconscious/Shared/Components/Settings/SettingsView.swift
Outdated
Show resolved
Hide resolved
...ubconscious/Subconscious.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should allow changing the invite code, at least in the settings, and probably in the FRE? If you put in the wrong invite code in this PR, there would be no recovery path.
I recently attempted to re-use invite code during a playtest, with a predictable failure. However, without a way to write in a new invite code, I believe I would have been bricked #738
Based on feedback here and the work we're doing in https://github.com/subconsciousnetwork/subconscious-cloud/issues/6 I think we should rethink the overall flow here a little. We can address #737 and #738 easily once https://github.com/subconsciousnetwork/subconscious-cloud/issues/6 lands. |
Doing some modelling to explore how things would work after https://github.com/subconsciousnetwork/subconscious-cloud/issues/6 lands. @gordonbrander let me know what you think, especially about my callout here RE: trying to redeem a code multiple times.
|
Clarifying the current planned changes in the redemption, mostly compatible with the flow above:
|
Amazing! Thanks @jsantell, I had a quick read over https://github.com/subconsciousnetwork/subconscious-cloud/pull/7/files#diff-e1e65eeceb23dd47013779351844a41a2b781e987c92db2bb0d4fa60d51703b9 and updated the diagram with a few more details. |
8208a84
to
410ff62
Compare
xcode/Subconscious/Shared/Components/Common/Forms/ValidatedTextField.swift
Show resolved
Hide resolved
xcode/Subconscious/Shared/Components/FirstRun/FirstRunView.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Haven't test-driven, but nothing looks unusual or out-of-place to me. Good improvements!
xcode/Subconscious/Shared/Components/Common/Forms/ValidatedTextField.swift
Show resolved
Hide resolved
xcode/Subconscious/Shared/Components/FirstRun/FirstRunView.swift
Outdated
Show resolved
Hide resolved
xcode/Subconscious/Shared/Components/Settings/GatewayURLSettingsView.swift
Outdated
Show resolved
Hide resolved
xcode/Subconscious/Shared/Components/Settings/GatewayURLSettingsView.swift
Outdated
Show resolved
Hide resolved
Remodel with explicit actions instead
dbed589
to
99ff1be
Compare
Fixes #715
Fixes #697
Fixes #738
Fixes #763
Fixes #737
Demo
I can't record a fresh demo right now since the cluster is down, I recommend playtesting the app. But here's a slightly stale video of the new settings layout. All the gateway settings are together now, it's maybe a bit confronting for users but they have full control to pick-up the process at any point it failed.
Screen_Recording_2023-06-28_at_1.44.19_pm.mov
First Run
Settings
Rework the invite code flow to ensure the code is actually valid. See screenshots in comments throughout.
isValid
abstraction.pushStep
for FirstRun