This repository has been archived by the owner on Aug 11, 2024. It is now read-only.
Report uncaught exceptions with sentry.io #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfollington
reviewed
Jun 20, 2023
bfollington
reviewed
Jun 20, 2023
| ); | ||
| runOnlyForDeploymentPostprocessing = 0; | ||
| shellPath = /bin/sh; | ||
| shellScript = "if which sentry-cli >/dev/null; then\nexport SENTRY_ORG=subconscious\nexport SENTRY_PROJECT=apple-ios\nexport SENTRY_AUTH_TOKEN=cfb08a61febc418bb55ec80ae6f99e2ce34b93d5b179454e9a8b8c240a3bb4d6\nERROR=$(sentry-cli debug-files upload \"$DWARF_DSYM_FOLDER_PATH\" 2>&1 >/dev/null)\nif [ ! $? -eq 0 ]; then\necho \"warning: sentry-cli - $ERROR\"\nfi\nelse\necho \"warning: sentry-cli not installed. download from https://github.com/getsentry/sentry-cli/releases\"\nfi\n"; |
There was a problem hiding this comment.
Is it okay for this auth token to be publicly checked in? Bearing in mind this repo is fully open-source.
This issue seems to suggest we shouldn't check it in: getsentry/sentry-react-native#1096
bfollington
reviewed
Jun 20, 2023
|
That token has been revoked. Good catch. I'll work w/ you in DM to figure out how to pass in relevant secrets. |
bfollington
approved these changes
Jun 21, 2023
bfollington
added a commit
that referenced
this pull request
Jun 24, 2023
Extends #740 Use `OSLogEnumerator` to pin the app logs to the reported error. This probably isn't super efficient but given the nature of reporting a crash, that's probably ok.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still need to upload debug symbols for release builds.