-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉 Add advanced setting to allow all website access permission. #196
Conversation
Woohoo! Great demo gif, also! Couple of quick questions about how you chose to do this.
BTW, I'm giving a talk about this project on Tuesday, and I have a slide to mention how cool it has been that contributors like you have come along to pick up features and bugs reports. Thanks! |
…rectly in permission requesting, removing (subdavis#168)
@subdavis thanks for the feedback ad 1. Good to know for the future :D Great to hear you like the contributions. |
@zmilonas looks like there are some conflicts here. Once those get sorted out, we can merge. |
@subdavis conflicts resolved :) |
Opened #199 to tackle some of the anomalies in options page styles. Otherwise, LGTM. |
I don't know if I'm losing my mind, but this broke.
I remember testing this PR and it working. I'm on This is now the same thing that Firefox does as mentioned in the README. Can you reproduce, @zmilonas? I'm running on commit 95ffcd9 |
@ubdavis |
Just try to toggle on this feature from advanced settings. What version of Chrome are you on, and what platform? |
Closes #168
Tested with Chrome 69 on macOS
Demo screen recording here: https://gfycat.com/ForthrightDefensiveIberianemeraldlizard