[C#] support class definitions without a body #4120
+81
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - include: terminator | ||
| - match: (?=\S) | ||
| pop: true | ||
| pop: 1 |
There was a problem hiding this comment.
Not important, but you use pop: true for the rest of the commit (except the pop: 2).
deathaxe
reviewed
Dec 27, 2024
| /// ^^^^^^^^^^^^^^^^^^^^^^^ meta.class.cs | ||
| /// ^ punctuation.separator.type.cs | ||
| /// ^^^^^^^^^ entity.other.inherited-class.cs | ||
| /// ^^^^^^^^^^ meta.function-call.cs meta.group.cs |
There was a problem hiding this comment.
meta.function-call feels off somehow in combination with inherited-class.
There was a problem hiding this comment.
But logically we want it scoped like a normal function call I believe, a constructor is just a special type of function 🙂 I think other constructor calls are like that, though I'm not at a computer to check right now. Like new SomeClass("this is a constructor call")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4119
plus converts some anonymous contexts into named contexts